rendermodels: support standard pose components in GetComponentState - #404
Open
exstrim401 wants to merge 1 commit into
Open
rendermodels: support standard pose components in GetComponentState#404exstrim401 wants to merge 1 commit into
exstrim401 wants to merge 1 commit into
Conversation
SteamVR registers standard pose components (/pose/raw, /pose/tip) for every controller, for all render models. Games can look these up by their well-known names. They do not have to enumerate the components. xrizer accepted only its synthetic "xrizer_component". Thus a lookup for "tip" always returned false. The BigWalkVR mod marks a controller pose as invalid if GetComponentState(model, "tip") fails. Under xrizer, the hands never moved, but the buttons continued to work. Accept the standard pose component names (tip, base, handgrip, grip) for known render models. Return identity transforms, because our models contain their offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SteamVR registers standard pose components (/pose/raw, /pose/tip) for every controller, for all render models. Games can look these up by their well-known names. They do not have to enumerate the components. xrizer accepted only its synthetic "xrizer_component". Thus a lookup for "tip" always returned false.
The BigWalkVR mod marks a controller pose as invalid if GetComponentState(model, "tip") fails. Under xrizer, the hands never moved, but the buttons continued to work.
Accept the standard pose component names (tip, base, handgrip, grip) for known render models. Return identity transforms, because our models contain their offsets.
Fixes #403
Claude Fable 5 assisted