Add support for Background and Utility application types - #330
Open
openglfreak wants to merge 3 commits into
Open
Add support for Background and Utility application types#330openglfreak wants to merge 3 commits into
openglfreak wants to merge 3 commits into
Conversation
Supreeeme
reviewed
Apr 8, 2026
| impl GraphicsBackend for GlData { | ||
| type Api = xr::OpenGL; | ||
| type OpenVrTexture = gl::types::GLuint; | ||
| type Format = u32; |
Owner
There was a problem hiding this comment.
Format can be pulled from the Api so I don't think it necessarily needs to be another associated type.
Comment on lines
+127
to
+130
| vr::EVRApplicationType::Utility => { | ||
| supported_exts.mnd_headless && supported_exts.khr_convert_timespec_time | ||
| } | ||
| vr::EVRApplicationType::Background => { |
Owner
There was a problem hiding this comment.
Suggested change
| vr::EVRApplicationType::Utility => { | |
| supported_exts.mnd_headless && supported_exts.khr_convert_timespec_time | |
| } | |
| vr::EVRApplicationType::Background => { | |
| vr::EVRApplicationType::Utility | vr::EVRApplicationType::Background => { |
Comment on lines
+148
to
+149
| exts.mnd_headless = supported_exts.mnd_headless; | ||
| exts.khr_convert_timespec_time = supported_exts.khr_convert_timespec_time; |
Owner
There was a problem hiding this comment.
Suggested change
| exts.mnd_headless = supported_exts.mnd_headless; | |
| exts.khr_convert_timespec_time = supported_exts.khr_convert_timespec_time; | |
| exts.mnd_headless = true; | |
| exts.khr_convert_timespec_time = true; |
| } | ||
|
|
||
| fn to_openxr_format(_format: Self::Format) -> <Self::Api as xr::Graphics>::Format { | ||
| panic!() |
Owner
There was a problem hiding this comment.
Suggested change
| panic!() | |
| unimplemented!() |
Comment on lines
+75
to
+88
| /*let raw_format = 0u32; | ||
| let format = *unsafe { &raw_format as &xr::headless::HeadlessFormat }; | ||
| xr::SwapchainCreateInfo { | ||
| create_flags: xr::SwapchainCreateFlags::EMPTY, | ||
| usage_flags: xr::SwapchainUsageFlags::TRANSFER_DST, | ||
| format, | ||
| sample_count: 1, | ||
| width: 0u32, | ||
| height: 0u32, | ||
| face_count: 1, | ||
| array_size: 2, | ||
| mip_count: 1, | ||
| }*/ | ||
| panic!(); |
Owner
There was a problem hiding this comment.
Suggested change
| /*let raw_format = 0u32; | |
| let format = *unsafe { &raw_format as &xr::headless::HeadlessFormat }; | |
| xr::SwapchainCreateInfo { | |
| create_flags: xr::SwapchainCreateFlags::EMPTY, | |
| usage_flags: xr::SwapchainUsageFlags::TRANSFER_DST, | |
| format, | |
| sample_count: 1, | |
| width: 0u32, | |
| height: 0u32, | |
| face_count: 1, | |
| array_size: 2, | |
| mip_count: 1, | |
| }*/ | |
| panic!(); | |
| unimplemented!() |
| } | ||
| } | ||
|
|
||
| impl GraphicsBackend for HeadlessData { |
Owner
There was a problem hiding this comment.
All of the GraphicsBackend functions should essentially be a noop for HeadlessData, because nothing should be rendered in a headless session. This begs the question, should HeadlessData even exist? It seems more like the GraphicalSession inside of SessionData should just be made into an Option<GraphicalSession>.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.