openxr_data: improve error message when app is using wrong GPU - #297
Open
ImSapphire wants to merge 1 commit into
Open
openxr_data: improve error message when app is using wrong GPU#297ImSapphire wants to merge 1 commit into
ImSapphire wants to merge 1 commit into
Conversation
Supreeeme
reviewed
Feb 8, 2026
Comment on lines
+441
to
+446
| let inst = unsafe { | ||
| ash::Instance::load( | ||
| ash::Entry::load().unwrap().static_fn(), | ||
| vk::Instance::from_raw(info.instance as _), | ||
| ) | ||
| }; |
Owner
There was a problem hiding this comment.
Might be worth also just finding a way to pass through the vulkan instance to this function.
Contributor
Author
There was a problem hiding this comment.
I can't really figure out a good way to do this because of how many abstractions the graphics backend and session restart code goes through. it seems like the VulkanData with the ash::Instance is dropped, so not sure that it's possible as-is?
Owner
There was a problem hiding this comment.
You should be able to pull it off the DynFrameController on the Compositor, with a simple match.
ImSapphire
force-pushed
the
improve-multi-gpu-error
branch
from
February 10, 2026 21:21
9470ae0 to
b068d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.