dont die on unexpected pose type - #233
Merged
Merged
Conversation
Contributor
|
this is a WIP extraction from the hl2vr-fixes branch: |
Owner
|
I guess potentially incorrect hand positions is better than no hand positions/input at all? And some of the pose types might just end up being the same as Given this, I guess I'll accept this over #234. |
Supreeeme
force-pushed
the
unexpected-pose-type
branch
from
November 26, 2025 22:04
fd4b10f to
958f088
Compare
Supreeeme
enabled auto-merge (rebase)
November 26, 2025 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered this in the case of ValheimVR (mod) which asks for
baseonvive_controllerandtouch_controller, as well ashandgriponindex_controller. When running onmainbranch, bindings would fail to load and thus not provide any input whatsoever. However, the same title works fine with OpenComposite.The docs hint at the fact that Raw and Tip are merely the ones that are always provided, with ability to add custom ones using external files.
Since we currently don't consider such files, the second best option would be to fall back to a sane default. A warning is left in place in order to help identify issues that stem from the fallback not being a good fit.