Skip to content

Add configurable summary quantile metrics via --metrics.mode flag - #258

Open
Alb0t wants to merge 1 commit into
SuperQ:masterfrom
Alb0t:ala/add-summary-quantile-metrics
Open

Alb0t wants to merge 1 commit into
SuperQ:masterfrom
Alb0t:ala/add-summary-quantile-metrics

Conversation

@Alb0t

@Alb0t Alb0t commented Aug 24, 2026

Copy link
Copy Markdown

Summary

  • Adds --metrics.mode flag to control latency metric type: histogram (default, unchanged behavior), summary (quantiles only), or both (histogram + summary side by side)
  • Adds --quantiles flag to specify which quantiles to track (default: 0.5,0.9,0.95,0.99)
  • In both mode, histogram keeps existing name smokeping_response_duration_seconds, summary uses smokeping_response_duration_summary_seconds to avoid _sum/_count collision
  • In summary-only mode, summary uses smokeping_response_duration_seconds for backward compatibility
  • Epsilon (accuracy) values are auto-assigned based on quantile position — not exposed to operators
  • Fully backward compatible: default behavior unchanged, no new metrics unless opted in
  • Config reload (SIGHUP / /-/reload) respects mode and quantile settings

Usage

Default — histogram only (unchanged)

smokeping_prober host1 host2

Both histogram buckets + summary quantiles

smokeping_prober --metrics.mode both host1 host2

Summary quantiles only, custom set

smokeping_prober --metrics.mode summary --quantiles "0.5,0.99" host1 host2

Adds --metrics.mode (histogram|summary|both) and --quantiles flags to
allow exporting pre-computed quantiles alongside or instead of histogram
buckets. Default behavior is unchanged (histogram only).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Albert Autin <albert.autin@thetradedesk.com>
@Alb0t
Alb0t force-pushed the ala/add-summary-quantile-metrics branch from a02fd2d to a111825 Compare August 24, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant