Skip to content

Update dashboard.json to use dynamic rate interval - #122

Open
iustin wants to merge 1 commit into
SuperQ:masterfrom
iustin:patch-1
Open

iustin wants to merge 1 commit into
SuperQ:masterfrom
iustin:patch-1

Conversation

@iustin

@iustin iustin commented Oct 31, 2023

Copy link
Copy Markdown

Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current 1m assumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with $__rate_interval which should deal with things automatically in most cases.

@iustin

iustin commented Mar 5, 2024

Copy link
Copy Markdown
Author

Friendly ping.

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SuperQ

SuperQ commented Mar 5, 2024

Copy link
Copy Markdown
Owner

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current `1m` assumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with `$__rate_interval` which should deal with things automatically in most cases.

Signed-off-by: Iustin Pop <iustin@k1024.org>
@iustin

iustin commented Mar 5, 2024

Copy link
Copy Markdown
Author

Updated, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants