perf(renderer): reduce Raycast list render churn - #619
Closed
JustYannicc wants to merge 121 commits into
Closed
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ListItemRendererandListEmojiGridItemRendererwith render-relevant comparators that ignore inline selection/action callback identity.list-runtime.tsxso memoized rows keep activation behavior current even when DOM handlers are not refreshed on unrelated selection moves.scripts/measure-raycast-list-render-churn.mjsandscripts/test-list-emoji-render-churn.mjsto measure and assert list/emoji selection render churn.Why
Selection movement in
list-runtime.tsxcreates fresh row/cell callbacks for every visible list item and emoji cell. Without memoized leaf renderers, every visible row/cell re-rendered even though only the previously selected and newly selected items changed visually.Compatibility impact
No Raycast API surface changes. The comparators preserve visible/render-relevant props including selected state, data index, list text values,
assetsPath, icon references, and accessory references. Callback identity is intentionally ignored, with activation behavior reading the latest selection/action through refs.How tested
node --test scripts/test-list-emoji-render-churn.mjs scripts/test-list-conditional-virtual-rows.mjs scripts/test-emoji-grid-virtualization.mjs./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falsesrc/renderer/src/raycast-api/list-runtime-renderers.tsx: no diagnostics foundsrc/renderer/src/raycast-api/list-runtime.tsx: no diagnostics foundPerformance evidence
Before this change, with
SUPERCMD_NODE_MODULES=/Users/justyannicc/.codex/worktrees/3847/SuperCmd/node_modules node scripts/measure-raycast-list-render-churn.mjs --iterations=5 --warmups=1 --selection-steps=800 --json:selectionRenderChurn.listItemRenderCount:51200selectionRenderChurn.emojiGridItemRenderCount:89600listMedianDurationMs:566.0315emojiMedianDurationMs:417.1664After this change, with
node scripts/measure-raycast-list-render-churn.mjs --iterations=5 --warmups=1 --selection-steps=800 --json:selectionRenderChurn.listItemRenderCount:1600selectionRenderChurn.emojiGridItemRenderCount:1600listMedianDurationMs:86.1857emojiMedianDurationMs:102.6075Grid control check remains at the wave4 memo baseline shape:
node scripts/measure-raycast-grid-render-churn.mjs --iterations=5 --warmups=1 --selection-steps=800 --jsonreportedselectionRenderChurn.cellRenderCount: 1600.Stack validation
Started from branch
codex/perf-wave4-integrated-stack-20260705atac90ce403aeddab98d0a1b245afce268c48b8bfd;git rev-parse HEADwas verified before creatingcodex/perf-raycast-list-emoji-render-churn-20260705.Replaces
Wave5 performance implementation for Raycast list/emoji row render churn. Replaces no prior PR.