perf(list): reduce row render churn - #618
Closed
JustYannicc wants to merge 121 commits into
Closed
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ListItemRendererandListEmojiGridItemRendererwith focused comparators that track visible/data props and ignore handler identity churn.scripts/measure-raycast-list-render-churn.mjsto instrument list and emoji-row render churn.scripts/test-list-renderer-memoization.mjscovering comparator behavior and select/activate/context-menu callback wiring.Why
Selection, action overlay, scroll, and other parent state changes can recreate visible row handlers even when row visuals do not change. Before this change, that made every visible list row or emoji cell re-enter render. The grid path already had this memoization pattern, so list rows now match that lower-churn behavior.
Compatibility impact
No Raycast API behavior or extension-facing props were removed or changed. Selection styling, data indexes, assets path icon rendering, accessories, activation, hover selection, and context-menu behavior remain wired through the same props.
How tested
node --test scripts/test-list-renderer-memoization.mjsnode --test scripts/test-list-renderer-memoization.mjs scripts/test-list-registry-stable-order.mjsnode scripts/run-node-tests.mjs --exclude-perf(317 passed, 1 skipped)./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty false./node_modules/.bin/vite buildsrc/renderer/src/raycast-api/list-runtime-renderers.tsx: no diagnostics foundPerformance evidence
Benchmark command:
node scripts/measure-raycast-list-render-churn.mjs --visible-rows=80 --visible-emoji-cells=96 --selection-steps=300 --parent-updates=150 --iterations=5 --warmups=1Before:
After:
Stack validation
Started from
codex/perf-wave4-integrated-stack-20260705at exact SHAac90ce403aeddab98d0a1b245afce268c48b8bfd. Opened this branch asJustYannicc:codex/perf-list-grid-row-render-churntargetingSuperCmdLabs/SuperCmd:main.Validated the grid audit finding:
GridItemRendereralready usesReact.memowith a comparator that ignores handler identity. No grid-path changes were made because the list memoization produced the targeted churn reduction without touching virtualization behavior.Note:
npm run typecheck:rendereris blocked on this machine because the npm wrapper routes to pnpm and the repo parity check requires a real npm binary withpackage-lock.json; the equivalent underlying renderertsccommand passed directly.Replaces
None.