perf(files): reduce tombstone query overhead - #617
Closed
JustYannicc wants to merge 121 commits into
Closed
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Post-delete queries could spend tens of milliseconds after watcher delete batches because tombstoned IDs remained in prefix buckets and exact deleted-name misses fell through to Spotlight. The new path keeps dense tombstone buckets lean and avoids asking Spotlight to rediscover a name the index just tombstoned.
Compatibility impact
Raycast-facing result shapes and delete semantics are preserved: exact file deletes, directory descendant deletes, unknown-root descendant tombstones, prefix-like sibling safety, and nested delete collapse still pass. The Spotlight skip is limited to exact deleted-name tombstones when the live index has no result.
How tested
node scripts/test-file-search-delete-batch.mjsnode scripts/test-file-search-index.mjsnode scripts/test-file-search-perf-harness.mjs./node_modules/.bin/tsc -p tsconfig.main.json --noEmit --pretty falsenpm run build:mainvia real cached npm CLInpm run build:renderervia real cached npm CLInode scripts/build-native.mjsnpm testvia real cached npm CLIsrc/main/file-search-index.tsand workspace diagnostics; LSP references checked fortombstoneDeletedPathsgit diff --checkNote: top-level
npm run buildwas also attempted, but this machine's nested npm resolution fails before project build steps withCannot find module ... npm-prefix.js; running the component build steps directly passed.Performance evidence
Parent-sized harness (
node scripts/file-search-perf-harness.mjs --projects 40 --modules 6 --files-per-module 10 --query-runs 8 --updates 64 --deletes 64 --limit 20 --json):Larger delete-heavy harness (
--projects 80 --modules 8 --files-per-module 16 --query-runs 6 --updates 96 --deletes 256 --limit 20 --json):Focused delete benchmark after change (
node scripts/benchmark-file-search-delete-batch.mjs):Stack validation
Base was exact
ac90ce403aeddab98d0a1b245afce268c48b8bfdfromcodex/perf-wave4-integrated-stack-20260705. Branchcodex/perf-file-index-tombstones-wave5contains one commit:90df743 perf(files): reduce tombstone query overhead.Replaces
N/A