perf(menubar): reuse serialized items for title ticks - #616
Closed
JustYannicc wants to merge 121 commits into
Closed
perf(menubar): reuse serialized items for title ticks#616JustYannicc wants to merge 121 commits into
JustYannicc wants to merge 121 commits into
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Title-only menu-bar ticks were still sorting and serializing the full registered item tree, resolving every item and alternate icon, and hashing the full item payload before discovering that only tray-visible fields changed.
Compatibility impact
Registry, handler, submenu, alternate, section, disabled-label, icon, and extension-context behavior is preserved. Registry version or assets-path changes invalidate the item/action cache, and actions are still installed before unchanged visible payloads are skipped.
How tested
node --test scripts/test-menubar-payload-cache.mjs scripts/test-menubar-renderer-serialization-cache.mjsnode scripts/run-node-tests.mjs --exclude-perfPATH=/opt/homebrew/lib/node_modules/npm/bin:$PATH node /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js run typecheck:rendererPATH=/opt/homebrew/lib/node_modules/npm/bin:$PATH node /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js run build:renderermenubar-runtime-parent.tsxandmenubar-runtime-payload-cache.ts: no errorsPerformance evidence
Actual-module baseline before edits, 60 stable items with 12 alternates over 120 title ticks: 7,200 item serializer entries, 8,640 item icon payload calls, 120 tray icon payload calls, 120 IPC sends, 148.81 ms in the timer-based harness.
After edits with the same timer-based harness: 0 item serializer entries, 0 item icon payload calls, 120 tray icon payload calls, 120 IPC sends, 155.35 ms. That wall-clock sample is timer-harness dominated, so I also ran a direct
syncMenuBar-awaited comparison in the same process: cache-disabled shape 14.61 ms vs current cache 4.25 ms for the same 120 ticks, with item icon calls dropping from 8,640 to 0.Stack validation
Started from required branch state
codex/perf-wave4-integrated-stack-20260705atac90ce403aeddab98d0a1b245afce268c48b8bfd. Implementation branch iscodex/perf-menubar-renderer-serialize-cache-20260705, commit51242473dd126f4d9a8cbd84bfa6a1b99b9f81fb.Replaces
No previous PR. This replaces the parent audit's synthetic renderer serialization-cache model with measured actual-module behavior and regression coverage.