fix(validation): enforce root search perf budgets - #608
Closed
JustYannicc wants to merge 121 commits into
Closed
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
npm run test:perf:ciconfigured root-search budget env vars, butscripts/test-root-search-perf.mjsdid not read or enforce them, so threshold regressions could pass silently.Compatibility impact
How tested
env SUPERCMD_ROOT_SEARCH_PERF_COMMANDS=50 SUPERCMD_ROOT_SEARCH_PERF_ITERATIONS=1 SUPERCMD_ROOT_SEARCH_PERF_OPTIMIZED_MEDIAN_MS=100000 SUPERCMD_ROOT_SEARCH_PERF_INDEXED_MEDIAN_MS=100000 SUPERCMD_ROOT_SEARCH_PERF_COMPILE_MEDIAN_MS=100000 SUPERCMD_ROOT_SEARCH_PERF_INDEXED_SPEEDUP_MIN=0 node scripts/test-root-search-perf.mjspassed, real 0.31s.env SUPERCMD_ROOT_SEARCH_PERF_COMMANDS=50 SUPERCMD_ROOT_SEARCH_PERF_ITERATIONS=1 SUPERCMD_ROOT_SEARCH_PERF_OPTIMIZED_MEDIAN_MS=0.001 SUPERCMD_ROOT_SEARCH_PERF_INDEXED_MEDIAN_MS=0.001 SUPERCMD_ROOT_SEARCH_PERF_COMPILE_MEDIAN_MS=0.001 SUPERCMD_ROOT_SEARCH_PERF_INDEXED_SPEEDUP_MIN=999999 node scripts/test-root-search-perf.mjsfailed intentionally with exit 1, real 0.31s.node --test scripts/test-root-search-perf-budgets.mjspassed, real 0.74s.npm run test:perf:cipassed, real 24.73s.npm run test:cipassed, real 5.34s.npm run typecheck:rendererpassed, real 6.21s.npm run build:mainpassed, real 3.88s.npm run check:i18npassed, real 0.59s.Performance evidence
npm run test:perf:ci: passed in real 24.50s; root-search optimized median 614.34ms, indexed median 92.86ms, compile median 67.82ms, optimized-vs-indexed speedup 6.62x.npm run test:perf:ci: passed in real 24.73s; root-search optimized median 749.76ms <= 900ms, indexed median 106.30ms <= 350ms, compile median 82.16ms <= 500ms, optimized-vs-indexed speedup 7.05x >= 1.05x.Stack validation
codex/perf-wave4-integrated-stack-20260705commitac90ce403aeddab98d0a1b245afce268c48b8bfdwith a clean worktree, then branched tocodex/wave5-root-search-perf-budgets.npm run typecheck:rendererpassed.Replaces