fix: clean up extension spawn lifecycle - #585
Closed
JustYannicc wants to merge 115 commits into
Closed
Conversation
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # .github/workflows/project-checks.yml # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…-integration-stack-20260704
…-integration-stack-20260704
…-integration-stack-20260704
…e3-integration-stack-20260704
…erf-wave3-integration-stack-20260704 # Conflicts: # package.json # scripts/measure-extension-bundle-cache.mjs # scripts/test-icon-runtime-file-icon-cache.mjs # src/main/extension-runner.ts # src/renderer/src/components/HiddenExtensionRunners.tsx # src/renderer/src/raycast-api/icon-runtime-render.tsx
…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
child_process.spawn,exec, andexecFilechildren created through the renderer IPC shim.webContentsand reaps only that sender's children ondestroyedorrender-process-gone, while preserving explicitspawn-killbehavior.Why
Long-running extension child processes could survive ExtensionView unmounts, leaving renderer IPC listeners and main-process map entries alive until the child exited naturally.
Compatibility impact
Existing stdout/stderr streaming, terminal events, stdin forwarding, process-group termination,
spawn,exec,execFile, and legacy spawn IPC channels are preserved. Cleanup is scoped to the ExtensionView or originating sender so unrelated processes are not terminated.How tested
node --test scripts/test-extension-lifecycle-sandbox.mjsnpm run typecheck:renderernpm run build:mainsrc/renderer/src/ExtensionView.tsx: no diagnostics foundsrc/main/main.ts: no diagnostics foundnpm test(312tests reported,310passed,2skipped)Performance evidence
Before: active extension spawn cleanup was not part of the ExtensionView lifecycle registry, so an unmounted view could retain
1spawn IPC listener and1tracked long-running child until process exit.After:
scripts/test-extension-lifecycle-sandbox.mjslogsextension child_process lifecycle cleanup after fixwithactiveSpawnIpcListeners: 1 -> 0,trackedChildProcesses: 1 -> 0,cleanupCalls: 0 -> 1, andkillCalls: 0 -> 1when the registry is cleared.Stack validation
Started from
codex/perf-wave3-integration-stack-20260704at206eab8280a2eb91a57e4e74ea6df99e45a55cb4. Final branch commit:23ddb55106f837faf6bcbc8d0705ea696ebe5f75.Replaces
None.