fix: clear form snapshots on unmount by JustYannicc · Pull Request #582 · SuperCmdLabs/SuperCmd

JustYannicc · 2026-07-04T19:27:35Z

What changed

Added ownership-aware cleanup for Raycast Form runtime global submitted value, error, and placeholder snapshots when a Form unmounts.
Tagged snapshot writes from each mounted Form instance so an older unmount does not clear a newer active Form snapshot.
Added a focused Node harness that mounts, updates, and unmounts the Form runtime and measures retained snapshot keys and serialized bytes.

Why

Unmounted Form views left module-global snapshots populated for Action.SubmitForm, retaining submitted values, errors, placeholders, and any nested object graphs after the view was gone.

Compatibility impact

No public Raycast API behavior changes while a Form is mounted. getFormValues() still preserves placeholder fallback behavior for blank values, and existing submit semantics remain unchanged for mounted Forms.

How tested

node --test scripts/test-form-runtime-error-state-noop.mjs scripts/test-use-form-error-state-noop.mjs scripts/test-form-runtime-snapshot-cleanup.mjs
node scripts/test-form-runtime-snapshot-cleanup.mjs --report
npm run typecheck:renderer
Codex LSP status, references, and diagnostics on the edited Form runtime files.

Performance evidence

Focused snapshot harness report:

Before unmount: 6 retained snapshot keys, 1161 serialized bytes.
After unmount cleanup: 0 retained snapshot keys, 6 serialized bytes for three empty snapshot objects.

Stack validation

Started from codex/perf-wave3-integration-stack-20260704 at 206eab8280a2eb91a57e4e74ea6df99e45a55cb4. The implementation is limited to Form runtime snapshot cleanup and focused tests.

Replaces

None.

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx

…perf-wave2-integration-stack-20260704

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts

…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # .github/workflows/project-checks.yml # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/raycast-api/list-runtime.tsx

…-integration-stack-20260704

…e3-integration-stack-20260704

…erf-wave3-integration-stack-20260704 # Conflicts: # package.json # scripts/measure-extension-bundle-cache.mjs # scripts/test-icon-runtime-file-icon-cache.mjs # src/main/extension-runner.ts # src/renderer/src/components/HiddenExtensionRunners.tsx # src/renderer/src/raycast-api/icon-runtime-render.tsx

…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs

JustYannicc · 2026-07-05T00:35:52Z

Superseded by the clean consolidated wave4 renderer/Raycast PR: #599. That branch contains this PR's covered change on current main without the inherited broad-stack noise.

JustYannicc added 30 commits July 3, 2026 22:19

Batch AI chat stream updates

5ae51b3

Batch cursor prompt stream updates

18481a2

perf(ai): batch Raycast useAI streaming

be66d99

ci: add project regression checks

a1d8c7b

Add bundled TS import helper for tests

a1225c6

fix(types): make renderer typecheck clean

0799e71

ci(claude): fix review action on fork PRs

835bf3a

fix(i18n): restore Italian parity checks

4605c88

fix(pnpm): approve native build scripts

d4c6a9f

perf: cache local icon asset existence checks

986c87a

Virtualize emoji grid list rendering

9e4eed3

Memoize Phosphor icon resolution

5245253

Cache emoji caret session state

cfe2ec3

Stabilize list item registry order

83d6b0b

perf(launcher): window command list rendering

e03ad3e

perf(grid): virtualize grid rendering

f07b554

perf(settings): coalesce AI status polling

6f06eb4

perf(icons): coalesce file icon IPC

949a6fd

Remove root search ranking diagnostics

8ca7ec9

perf: optimize file search delete batches

fb857f2

perf: memoize frecency sorting defaults

dee7108

Avoid interval file-index rebuilds

68cb050

Avoid full script reads for command headers

9f246ce

Optimize root search command scoring

12f951e

perf(runtime): reduce extension and menubar churn

a2737ce

Speed up path-like file search queries

7ed6c2a

Add file search perf harness

dff8539

perf(browser-search): index hot query path

caa78e1

fix(browser-search): narrow indexed nickname candidates

321d103

test: trim benchmark script eof whitespace

644e72d

JustYannicc added 26 commits July 4, 2026 13:20

Merge remote-tracking branch 'refs/remotes/origin/pr/533' into codex/…

d6548bb

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx

Merge remote-tracking branch 'refs/remotes/origin/pr/534' into codex/…

8719131

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx

Merge remote-tracking branch 'refs/remotes/origin/pr/535' into codex/…

143cafe

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/555' into codex/…

ba47b63

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/556' into codex/…

fc4d48e

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/558' into codex/…

c710784

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/572' into codex/…

55817f4

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx

fix(list): preserve conditional virtual row behavior

34a04d4

perf(search): reuse renderer ranking work

33194c1

perf(runtime): reduce menu bar and background churn

4c180c6

perf(raycast): reduce runtime hook and registry churn

fbe3ece

perf(files): reduce main-process search and IPC cost

6bd8e50

perf(media): reduce audio and overlay churn

d38e957

perf(startup): reduce renderer and asset load cost

fc80ea6

test(perf): add search regression budgets

531a188

Merge branch 'codex/perf-wave3-renderer-search' into codex/perf-wave3…

73b25ec

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-file-index-main' into codex/perf-wave3…

1411f8b

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-raycast-runtime' into codex/perf-wave3…

ca9d081

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-ai-media-ui-retry' into codex/perf-wav…

81166b3

…e3-integration-stack-20260704

Merge branch 'codex/perf-wave3-validation-harnesses-retry' into codex…

33d0c68

…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs

test(perf): support CommonJS facade harness exports

206eab8

fix: clear form snapshots on unmount

fd3e9d5

JustYannicc mentioned this pull request Jul 5, 2026

perf(renderer): consolidate Raycast runtime hot paths #599

Open

JustYannicc closed this Jul 5, 2026

JustYannicc mentioned this pull request Jul 5, 2026

perf(runtime): consolidate extension lifecycle and media fixes #601

Closed

Navigation Menu

Uh oh!

Uh oh!

fix: clear form snapshots on unmount - #582

fix: clear form snapshots on unmount#582
JustYannicc wants to merge 115 commits into
SuperCmdLabs:mainfrom
JustYannicc:codex/form-runtime-snapshot-cleanup-20260704

JustYannicc commented Jul 4, 2026

Uh oh!

JustYannicc commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

JustYannicc commented Jul 4, 2026

What changed

Why

Compatibility impact

How tested

Performance evidence

Stack validation

Replaces

Uh oh!

JustYannicc commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant