perf(emoji): reuse inline picker matches while navigating - #567
Closed
JustYannicc wants to merge 71 commits into
Closed
perf(emoji): reuse inline picker matches while navigating#567JustYannicc wants to merge 71 commits into
JustYannicc wants to merge 71 commits into
Conversation
(cherry picked from commit fb7405f)
(cherry picked from commit 290a0f5)
(cherry picked from commit 3739cb0)
(cherry picked from commit c78d0b9)
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack # Conflicts: # src/renderer/src/CameraExtension.tsx
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack
…ated-integration-stack
… into codex/perf-consolidated-integration-stack
Collaborator
Author
|
Superseded by the consolidated wave-2 UI/runtime PR: #572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
handleEmojiTriggerNavand again inupdateEmojiPickerSelectionfor each left/right key.Compatibility impact
emoji-data.jsonsearch ordering produced during render.How tested
node --test scripts/test-inline-emoji-picker-match-cache.mjsnode --test 'scripts/test-*.mjs'(238 pass, 1 skip, 0 fail)./node_modules/.bin/tsc -p tsconfig.main.json --pretty falsesrc/main/main.ts: no error diagnostics; all-severity check showed only preexisting hint-level items outside this change.Performance evidence
src/main/emoji-data.jsonwith 1,870 entries, querysmi, 500 repeated sequences of 20 right-arrow navigation steps.113000; the VM path also asserts left/right/enter perform 0 additional searches after render.Stack validation
fork/codex/perf-consolidated-integration-stackat264fb89dc5c867d6c3d77bc4b95e26e235e326ea.codex/perf-emoji-picker-match-cache.2cbcf35(perf(emoji): reuse inline picker matches while navigating).Replaces