perf(icons): cache main icon IPC lookups - #536
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Renderer call sites outside the Raycast runtime can repeatedly ask the main process for the same icons. File icons currently hit
app.getFileIconevery time, while app icon data URLs shell out through the.appicon resolver. Caching successful data URLs and coalescing identical in-flight requests avoids duplicate native work without changing renderer APIs.Compatibility impact
How tested
node scripts/test-main-icon-ipc-cache.mjs./node_modules/.bin/tsc -p tsconfig.main.json --noEmit --pretty falsesrc/main/main.tsandsrc/main/icon-ipc-cache.tsgit diff --checkStack validation
Clean PR branch from
origin/main; cherry-picked only the scoped main icon IPC cache fix. No integration-stack commits are included.