fix(i18n): restore Italian parity checks - #521
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #532 (fix(validation): restore project checks), which consolidates this validation/build change with the related source PRs. Closing this PR in favor of the upstream replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scripts/check-i18n.mjsstrict for every locale file by default instead of only Korean.Why
The i18n parity check still exited successfully while reporting that
it.jsonwas missing two English keys. That made locale regressions easy to miss and left Italian users falling back for those settings labels.Compatibility impact
No runtime behavior changes beyond translated copy and stricter validation. The checker still supports
SUPERCMD_STRICT_LOCALESfor targeted runs.How tested
origin/main:node scripts/check-i18n.mjsexited 0 but reportedit: missing=2forsettings.ai.whisper.vocabularyandsettings.extensions.appSearchScope.node scripts/check-i18n.mjsreports OK for de, es, fr, it, ja, ko, ru, zh-Hans, and zh-Hant.src/renderer/src/i18n/locales/en.jsonandsrc/renderer/src/i18n/locales/it.jsonwith Node JSON.parse.scripts/check-i18n.mjs: no errors.Stack validation
This patch was found and validated from
codex/perf-integration-stack, which contains the current performance fix stack. The PR branch is intentionally cherry-picked ontoorigin/mainso the upstream PR diff stays scoped to this fix.