Add configurable and atomic checkpoint controls#15
Closed
Toti330 wants to merge 3 commits into
Closed
Conversation
Owner
|
Implemented in 58c5e39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit checkpoint frequency and overwrite controls, safer atomic checkpoint replacement, and validation for resume data.
Why this is useful
Checkpoint behavior was previously implicit and the main-loop sleep converted
0.1seconds to0 ms, causing continuous checkpoint writes. This PR makes checkpoint I/O deliberate, tunable, and safe to disable during measurement.Implementation
CHECKPOINT_FREQUENCY=none|very_low|low|medium|high|xhigh|atomic.60s,30s,10sdefault,1s,250ms, and100ms.CHECKPOINT_OVERWRITE=1to discard an existing resume file intentionally.Duration::from_secs_f32(0.1).Independence
This PR is based directly on
mainand has no feature-branch dependency. It can be merged independently of timing, diagnostics, tuning, preflight, and progress logging.Verification
cargo test --all-targets: 5 checkpoint tests passed.CHECKPOINT_FREQUENCY=none.Generated by GPT-5.6 Terra & Sol. Ideas from the author; implementation by AI.