Add opt-in pipeline runtime diagnostics#13
Open
Toti330 wants to merge 3 commits into
Open
Conversation
Owner
|
Partially implemented in 44e7c91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
DIAGNOSTICS=1, an opt-in end-of-run report for the generation-to-PostgreSQL pipeline.Why this is useful
It turns a single final throughput number into measurable evidence: generated CSV payload volume, worker generation cost, worker channel backpressure, writer connection and receive time, star/planet COPY time, commit time, transaction count, and actual batch sizes. This makes it possible to distinguish CPU generation pressure, queue pressure, transfer/COPY time, and commit cost.
Implementation
inserter/src/diagnostics.rswith lock-free aggregate counters.DIAGNOSTICS=1.run()returns early after diagnostics begins.Independence
This PR is based directly on
mainand is independently usable. It does not require precise timing, tuning, checkpoint, preflight, or progress logging changes.Verification
cargo test --all-targetspassed in the Rust Docker toolchain.BENCHMARK=1 DIAGNOSTICS=1smoke run emitted payload, generation, channel, writer, and batch diagnostics.Generated by GPT-5.6 Terra & Sol. Ideas from the author; implementation by AI.