Repository navigation
Prepare Cleanmeter 2.2.19 - #91
Conversation
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: ASSERTIVE
- Plan: Team
- Run ID:
dd5fc93f-8ca4-4206-8c40-fdf6212cafbd
⛔ Files ignored due to path filters: 2
tauri-app/package-lock.jsonis excluded by!**/package-lock.jsontauri-app/src-tauri/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing: 3
tauri-app/package.jsontauri-app/src-tauri/Cargo.tomltauri-app/src-tauri/tauri.conf.json
Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.
| "name": "cleanmeter", | ||
| "private": true, | ||
| "version": "2.2.18", | ||
| "version": "2.2.19", |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
-
🏁 Script executed:
set -e printf '%s\n' '--- package and test ---' nl -ba tauri-app/package.json | sed -n '1,30p' nl -ba tauri-app/scripts/test-feedback-email.mjs | sed -n '1,140p' printf '%s\n' '--- feedback references and configured routes ---' rg -n -F --glob '!node_modules' --glob '!dist' -e 'app_version' -e 'test-feedback-email' -e 'feedback' tauri-app/src tauri-app/scripts tauri-app/src-tauri .github 2>/dev/null | sed -n '1,240p' printf '%s\n' '--- changed files in requested comparison ---' git diff --no-ext-diff --unified=30 30401e85ea3d489680e2f442838b484b4cca63a5 30d7f848d9d5fe4e063fe1d23686e2013becc685 -- tauri-app/package.json tauri-app/scripts/test-feedback-email.mjs
Repository: SupaStellar/Cleanmeter
Length of output: 15398
🏁 Script executed:
printf '%s\n' '--- package ---' nl -ba tauri-app/package.json | sed -n '1,20p' printf '%s\n' '--- feedback test ---' nl -ba tauri-app/scripts/test-feedback-email.mjs | sed -n '1,100p' printf '%s\n' '--- feedback version consumers ---' rg -n -F --glob '!node_modules' --glob '!dist' -e 'app_version' -e 'feedback_email' -e 'feedback' tauri-app .github | sed -n '1,220p'
Repository: SupaStellar/Cleanmeter
Length of output: 12513
🐛 Suggested fix
-
- const fields = { name: input.name, message: input.message, app_version: '2.2.18', os: 'windows' }; + const fields = { name: input.name, message: input.message, app_version: '2.2.19', os: 'windows' };
Keep the feedback test aligned with the release version.
The test bypasses the desktop transport and posts app_version: '2.2.18' directly. The release version is 2.2.19, so the test submits stale metadata. Read the version from package metadata or update this value with the release.
Prepares Cleanmeter 2.2.19 after the optional feedback email and Vite updates. The release build reads the rotated feedback credential from GitHub Actions.
Only the package, lockfile, Cargo, and Tauri versions change. The Windows installer was built and checked locally with the same application source; 195 frontend, 46 Rust, and 41 HardwareMonitor tests passed, along with lint and the email browser checks.
Create the Windows release as a draft with updater signatures. Do not publish it.