Repository navigation
Refresh overlay positioning after boot display changes - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlay reads monitor geometry only once during startup. If Windows initially reports no displays or later changes their geometry, placement continues using the initial snapshot. A DPI change can also leave CSS dimensions unchanged without triggering ResizeObserver.
Wait for saved settings before positioning, refresh display enumeration every two seconds, and reapply placement when geometry or DPI changes. Preserve saved coordinates, retain the last usable geometry during transient failures, prevent overlapping reads, and clean up subscriptions and pending responses on unmount.
This addresses startup positioning gaps found while investigating the boot-position feedback. The supplied logs contain no display geometry or saved coordinates, so the reporter's exact failure still needs on-device confirmation.
Validation: 15 tests passed across display refresh and pixel-shift suites; production frontend build and git diff --check passed. Full TypeScript checking still has existing errors in unchanged files. Manual Windows boot and mixed-DPI verification remain pending.