Repository navigation
Show N/A for invalid GPU wattage readings - #86
Merged
Merged
Conversation
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Team
- Run ID:
369c28cb-8f0c-4939-86cd-ae1c309a705b
📒 Files selected for processing: 3
tauri-app/src/components/overlay/GpuSection.tsxtauri-app/src/lib/gpu-power.test.tstauri-app/src/lib/gpu.ts
Included review availability: This review used your included allowance. 6 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A v2.2.18 feedback screenshot shows GPU power as 65,413 W. The overlay currently renders the sensor value without validation.
Validate that the configured reading is a power sensor on the selected GPU, finite, nonnegative, and no greater than a generous 2,000 W corruption ceiling. Missing or invalid samples display N/A; subsequent valid readings recover automatically. Valid watt values are preserved without guessing a unit conversion.
This prevents bogus output but does not establish why the driver produced the reported value: the supplied diagnostics contain no raw power samples or selected sensor ID.
Validation: 74 tests passed across GPU power, GPU selection, and settings-store GPU suites; production frontend build and git diff --check passed. Full TypeScript checking still has existing errors in unchanged files. Verification on the affected laptop remains pending.