Repository navigation
Add app interactions, sound effects, and shared Storybook controls - #83
Merged
Merged
Conversation
apyfz
force-pushed
the
feat/interactions-and-sound-effects
branch
2 times, most recently
from
October 16, 2026 22:53
616c931 to
ac5fa9e
Compare
apyfz
force-pushed
the
feat/interactions-and-sound-effects
branch
from
October 16, 2026 22:53
ac5fa9e to
e826d67
Compare
apyfz
marked this pull request as ready for review
October 19, 2026 19:02
There was a problem hiding this comment.
Actionable comments posted: 8
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Team
- Run ID:
b38d69ea-88c6-44e0-bf00-dbe593a3729c
⛔ Files ignored due to path filters: 1
tauri-app/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing: 67
THIRD-PARTY-NOTICES.mddocs/sound-effects.mdtauri-app/.gitignoretauri-app/package.jsontauri-app/patches/cuelume+0.2.8.patchtauri-app/patches/cuelume-legacy+0.2.2.patchtauri-app/scripts/test-checkbox-motion.mjstauri-app/scripts/test-control-motion.mjstauri-app/scripts/test-legacy-audio.mjstauri-app/scripts/test-remaining-motion.mjstauri-app/scripts/test-sound-effects.mjstauri-app/scripts/test-storybook-motion.mjstauri-app/sound-lab/index.htmltauri-app/sound-lab/main.jstauri-app/src-tauri/src/commands.rstauri-app/src-tauri/src/lib.rstauri-app/src-tauri/src/settings.rstauri-app/src-tauri/src/types.rstauri-app/src/App.tsxtauri-app/src/app/components/Checkbox.tsxtauri-app/src/app/components/NavigationTabs.tsxtauri-app/src/app/components/Select.tsxtauri-app/src/app/components/Toggle.tsxtauri-app/src/app/components/stories/Checkbox.stories.tsxtauri-app/src/app/components/stories/Interactions.stories.tsxtauri-app/src/app/components/stories/NavigationTabs.stories.tsxtauri-app/src/app/components/stories/Select.stories.tsxtauri-app/src/app/components/stories/Toggle.stories.tsxtauri-app/src/app/disclosure-motion.csstauri-app/src/app/globals.csstauri-app/src/app/motion.csstauri-app/src/components/settings/TabNav.tsxtauri-app/src/components/settings/TabPanels.tsxtauri-app/src/components/settings/TopBar.tsxtauri-app/src/components/settings/help/HelpTab.tsxtauri-app/src/components/settings/settings/FeedbackDialog.tsxtauri-app/src/components/settings/settings/PixelShiftControls.tsxtauri-app/src/components/settings/settings/SettingsTab.tsxtauri-app/src/components/settings/stats/CpuSection.tsxtauri-app/src/components/settings/stats/FpsSection.tsxtauri-app/src/components/settings/stats/GpuSection.tsxtauri-app/src/components/settings/stats/MonitorSection.tsxtauri-app/src/components/settings/stats/NetworkSection.tsxtauri-app/src/components/settings/stats/RamSection.tsxtauri-app/src/components/settings/stats/SectionCard.tsxtauri-app/src/components/settings/style/CollapsibleCard.tsxtauri-app/src/components/settings/style/FontCard.tsxtauri-app/src/components/settings/style/GraphTypePicker.tsxtauri-app/src/components/settings/style/OrientationPicker.tsxtauri-app/src/components/settings/style/PositionGrid.tsxtauri-app/src/components/shadcn/checkbox.tsxtauri-app/src/components/shadcn/collapsible.tsxtauri-app/src/components/shadcn/dialog.tsxtauri-app/src/components/shadcn/select.tsxtauri-app/src/components/shadcn/switch.tsxtauri-app/src/components/shadcn/tooltip.tsxtauri-app/src/components/ui/Disclosure.tsxtauri-app/src/components/ui/Toast.tsxtauri-app/src/lib/audio-session.test.tstauri-app/src/lib/audio-session.tstauri-app/src/lib/settings-actions.tstauri-app/src/lib/sound-effects.test.tstauri-app/src/lib/sound-effects.tstauri-app/src/lib/types.tstauri-app/src/stores/settings-store.reset.test.tstauri-app/src/stores/settings-store.sound.test.tstauri-app/src/stores/settings-store.ts
💤 Files with no reviewable changes: 1
- tauri-app/src/components/shadcn/select.tsx
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Team
- Run ID:
bdd3df1d-df7f-49a3-bb26-a81c855a4960
📒 Files selected for processing: 11
tauri-app/scripts/test-control-motion.mjstauri-app/scripts/test-remaining-motion.mjstauri-app/sound-lab/index.htmltauri-app/sound-lab/main.jstauri-app/src/app/components/stories/NavigationTabs.stories.tsxtauri-app/src/app/disclosure-motion.csstauri-app/src/components/settings/TabNav.tsxtauri-app/src/components/settings/TabPanels.tsxtauri-app/src/components/shadcn/switch.tsxtauri-app/src/stores/settings-store.sound.test.tstauri-app/src/stores/settings-store.ts
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanmeter settings now animate consistently across the app and Storybook, with selective sound feedback and a persisted Sound effects setting. Switches use Cuelume 0.2.2's toggle sound; checkboxes use its press sound. Other actions use Cuelume 0.2.8, including a softer feedback-dialog opening cue.
Changes
/sound-lab/.Bugs addressed
Validation
Remaining release validation
Ready for internal testing. Broader audio-output and taskbar-use validation remain before release. See
docs/sound-effects.mdfor implementation details.