Skip to content

Add app interactions, sound effects, and shared Storybook controls - #83

Merged
apyfz merged 3 commits into
mainfrom
feat/interactions-and-sound-effects
Oct 19, 2026
Merged

apyfz merged 3 commits into
mainfrom
feat/interactions-and-sound-effects

Conversation

@apyfz

@apyfz apyfz commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Cleanmeter settings now animate consistently across the app and Storybook, with selective sound feedback and a persisted Sound effects setting. Switches use Cuelume 0.2.2's toggle sound; checkboxes use its press sound. Other actions use Cuelume 0.2.8, including a softer feedback-dialog opening cue.

Changes

  • Add motion to tabs and tab content, dropdowns, switches, drawn checkmarks, accordions, panels, dialogs, toasts and tooltips. Preserve reduced-motion behavior, keyboard access and tab state.
  • Share control implementations between the app, design-system adapters and Storybook. Include a local sound playground at /sound-lab/.
  • Persist sound preferences and mute active and pending sounds across both library versions. Keep navigation, hover, sliders and background updates silent.
  • Prepare audio nodes before scheduling short sounds. Maintain audio readiness only while Windows settings are focused, visible and unmuted, using a 20 Hz signal at gain 0.0005.

Bugs addressed

  • Restore keyboard focus after closing the feedback dialog.
  • Reassert native overlay Z order. Taskbar overlap behavior still needs validation during normal desktop use.

Validation

  • Full ESLint, 181 frontend unit tests and 43 Rust unit tests passed.
  • Clippy completed with existing warnings.
  • Selected Storybook tests and browser audio/motion checks passed, including mute, keyboard use, rapid input and reduced motion.
  • Both dependency patches applied successfully in a fresh installation.
  • Frontend, Storybook and Windows installer builds passed.
  • Five existing TypeScript diagnostics remain; no new diagnostics.

Remaining release validation

  • Visual and listening review completed with Mars, as reported in the team update
  • Validate audio readiness across more outputs
  • Confirm overlay/taskbar stacking during normal use

Ready for internal testing. Broader audio-output and taskbar-use validation remain before release. See docs/sound-effects.md for implementation details.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

The pull request adds configurable interaction sounds with persisted preferences and audio readiness handling. It updates shared controls, motion behavior, and disclosure panels. It adds browser and unit tests, a Sound Lab, and Cuelume license details. The overlay heartbeat now refreshes native window stacking.

Changes: Sound Effects

Layer / File(s) Summary
Cuelume integration
tauri-app/package.json, tauri-app/patches/*, THIRD-PARTY-NOTICES.md
Adds current and legacy Cuelume packages and patches their audio scheduling and mute behavior. Adds the Cuelume notice.
Sound preference and playback state
tauri-app/src-tauri/src/types.rs, tauri-app/src-tauri/src/settings.rs, tauri-app/src/lib/types.ts, tauri-app/src/stores/settings-store.ts, tauri-app/src/lib/audio-session.ts, tauri-app/src/lib/sound-effects.ts, tauri-app/src/lib/settings-actions.ts, related tests
Adds a persisted sound preference with a default enabled value. Serializes preference saves and connects sound playback to preference, focus, visibility, and mute state.
Sound cues and browser validation
tauri-app/src/components/settings/..., tauri-app/sound-lab/*, tauri-app/scripts/test-sound-effects.mjs, tauri-app/scripts/test-legacy-audio.mjs, docs/sound-effects.md
Adds sound cues to settings and feedback interactions. Adds a Sound Lab and browser checks for audio output and mute behavior.

UI Motion and Shared Components

Layer / File(s) Summary
Motion primitives and styles
tauri-app/src/app/motion.css, tauri-app/src/app/disclosure-motion.css, tauri-app/src/components/ui/Disclosure.tsx, tauri-app/src/components/shadcn/*
Adds motion styles and reduced-motion rules for controls, disclosures, dialogs, toasts, and tooltips. Shared components add disclosure behavior and dialog focus restoration.
Controls, disclosures, and tab panels
tauri-app/src/app/components/{Checkbox,NavigationTabs,Select,Toggle}.tsx, tauri-app/src/App.tsx, tauri-app/src/components/settings/...
Reuses shared controls, applies disclosures to settings sections, and renders tab panels with tab associations and inactive-state handling.
Storybook and motion checks
tauri-app/src/app/components/stories/*, tauri-app/scripts/test-*-motion.mjs
Updates Storybook examples and adds browser checks for control, tab, and interaction behavior under standard and reduced-motion settings.

Overlay Z-Order

Layer / File(s) Summary
Refresh visible overlay stacking
tauri-app/src-tauri/src/commands.rs, tauri-app/src-tauri/src/lib.rs
The overlay display path and heartbeat call a helper that refreshes native stacking on Windows and retains the existing setter on other platforms.

Priority: ⬇️ Low

Merge Risk: 🟡 Moderate · up to 748b7

The overlay may cover a docked taskbar, and editing settings after a failed preference read may replace saved values. Resolve these risks before merging unless explicitly accepted.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 27.40% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 73 functions across 52 files. (2 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely summarizes the main changes: app interactions, sound effects, and shared Storybook controls.
Description check Passed The description is directly related to the changeset and provides detailed coverage of animations, sound behavior, persistence, validation, and remaining release checks.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 27.40% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 73 functions across 52 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@apyfz
apyfz force-pushed the feat/interactions-and-sound-effects branch 2 times, most recently from 616c931 to ac5fa9e Compare October 16, 2026 22:53
@apyfz
apyfz force-pushed the feat/interactions-and-sound-effects branch from ac5fa9e to e826d67 Compare October 16, 2026 22:53
@apyfz
apyfz marked this pull request as ready for review October 19, 2026 19:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: b38d69ea-88c6-44e0-bf00-dbe593a3729c
📥 Commits

Reviewing files that changed from the base of the PR and between 0eb9f7c and e826d67.

⛔ Files ignored due to path filters: 1
  • tauri-app/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 67
  • THIRD-PARTY-NOTICES.md
  • docs/sound-effects.md
  • tauri-app/.gitignore
  • tauri-app/package.json
  • tauri-app/patches/cuelume+0.2.8.patch
  • tauri-app/patches/cuelume-legacy+0.2.2.patch
  • tauri-app/scripts/test-checkbox-motion.mjs
  • tauri-app/scripts/test-control-motion.mjs
  • tauri-app/scripts/test-legacy-audio.mjs
  • tauri-app/scripts/test-remaining-motion.mjs
  • tauri-app/scripts/test-sound-effects.mjs
  • tauri-app/scripts/test-storybook-motion.mjs
  • tauri-app/sound-lab/index.html
  • tauri-app/sound-lab/main.js
  • tauri-app/src-tauri/src/commands.rs
  • tauri-app/src-tauri/src/lib.rs
  • tauri-app/src-tauri/src/settings.rs
  • tauri-app/src-tauri/src/types.rs
  • tauri-app/src/App.tsx
  • tauri-app/src/app/components/Checkbox.tsx
  • tauri-app/src/app/components/NavigationTabs.tsx
  • tauri-app/src/app/components/Select.tsx
  • tauri-app/src/app/components/Toggle.tsx
  • tauri-app/src/app/components/stories/Checkbox.stories.tsx
  • tauri-app/src/app/components/stories/Interactions.stories.tsx
  • tauri-app/src/app/components/stories/NavigationTabs.stories.tsx
  • tauri-app/src/app/components/stories/Select.stories.tsx
  • tauri-app/src/app/components/stories/Toggle.stories.tsx
  • tauri-app/src/app/disclosure-motion.css
  • tauri-app/src/app/globals.css
  • tauri-app/src/app/motion.css
  • tauri-app/src/components/settings/TabNav.tsx
  • tauri-app/src/components/settings/TabPanels.tsx
  • tauri-app/src/components/settings/TopBar.tsx
  • tauri-app/src/components/settings/help/HelpTab.tsx
  • tauri-app/src/components/settings/settings/FeedbackDialog.tsx
  • tauri-app/src/components/settings/settings/PixelShiftControls.tsx
  • tauri-app/src/components/settings/settings/SettingsTab.tsx
  • tauri-app/src/components/settings/stats/CpuSection.tsx
  • tauri-app/src/components/settings/stats/FpsSection.tsx
  • tauri-app/src/components/settings/stats/GpuSection.tsx
  • tauri-app/src/components/settings/stats/MonitorSection.tsx
  • tauri-app/src/components/settings/stats/NetworkSection.tsx
  • tauri-app/src/components/settings/stats/RamSection.tsx
  • tauri-app/src/components/settings/stats/SectionCard.tsx
  • tauri-app/src/components/settings/style/CollapsibleCard.tsx
  • tauri-app/src/components/settings/style/FontCard.tsx
  • tauri-app/src/components/settings/style/GraphTypePicker.tsx
  • tauri-app/src/components/settings/style/OrientationPicker.tsx
  • tauri-app/src/components/settings/style/PositionGrid.tsx
  • tauri-app/src/components/shadcn/checkbox.tsx
  • tauri-app/src/components/shadcn/collapsible.tsx
  • tauri-app/src/components/shadcn/dialog.tsx
  • tauri-app/src/components/shadcn/select.tsx
  • tauri-app/src/components/shadcn/switch.tsx
  • tauri-app/src/components/shadcn/tooltip.tsx
  • tauri-app/src/components/ui/Disclosure.tsx
  • tauri-app/src/components/ui/Toast.tsx
  • tauri-app/src/lib/audio-session.test.ts
  • tauri-app/src/lib/audio-session.ts
  • tauri-app/src/lib/settings-actions.ts
  • tauri-app/src/lib/sound-effects.test.ts
  • tauri-app/src/lib/sound-effects.ts
  • tauri-app/src/lib/types.ts
  • tauri-app/src/stores/settings-store.reset.test.ts
  • tauri-app/src/stores/settings-store.sound.test.ts
  • tauri-app/src/stores/settings-store.ts
💤 Files with no reviewable changes: 1
  • tauri-app/src/components/shadcn/select.tsx

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

Comment thread tauri-app/sound-lab/index.html Resolved
Comment thread tauri-app/sound-lab/main.js Resolved
Comment thread tauri-app/src-tauri/src/commands.rs Resolved
Comment thread tauri-app/src/app/disclosure-motion.css Resolved
Comment thread tauri-app/src/stores/settings-store.ts Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: bdd3df1d-df7f-49a3-bb26-a81c855a4960
📥 Commits

Reviewing files that changed from the base of the PR and between e826d67 and 748b7b8.

📒 Files selected for processing: 11
  • tauri-app/scripts/test-control-motion.mjs
  • tauri-app/scripts/test-remaining-motion.mjs
  • tauri-app/sound-lab/index.html
  • tauri-app/sound-lab/main.js
  • tauri-app/src/app/components/stories/NavigationTabs.stories.tsx
  • tauri-app/src/app/disclosure-motion.css
  • tauri-app/src/components/settings/TabNav.tsx
  • tauri-app/src/components/settings/TabPanels.tsx
  • tauri-app/src/components/shadcn/switch.tsx
  • tauri-app/src/stores/settings-store.sound.test.ts
  • tauri-app/src/stores/settings-store.ts

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

Comment thread tauri-app/src/stores/settings-store.ts Resolved
@apyfz
apyfz merged commit 96252e1 into main Oct 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant