Skip to content

[windows/audio] Process-tree capture + identity handoff (follow-up to #5935) #6121

Closed as not planned

Description

@mikefaille

Follow-up to #5935 per scope agreement #5935 (comment).

Moved scope: the new process-tree capture / identity-handoff path (process loopback capture gating, process identity carried through the capture handoff, session guard + params bundle + heap-owned activation blob) moves out of #5935 together with its associated test additions. #5935 preserves the existing Windows capture-only behavior. This issue also carries the P2 producer-test correction (P2: #5935 (comment)).

Source: branch backup/feat-audio-keep-default-sink-pre-stack-431886be at 431886be491f5c9ae7301088ab9880a9a0bc12c4 (fork mikefaille/Sunshine). Original commits: d3dc65fa (unified process loopback), c7da3dc3 (session guard/params/activation blob), 8f29179d (loopback activation alive + process gate), d8b01de7 (timeout completion-field reads), 431886be (identity handoff), plus test additions in tests/unit/test_process.cpp.

Acceptance gates:

  • AppProcessIdentityProviderTracksRealChildLifecycle moved outside the POSIX guard with a Windows command variant (cmd.exe /c ping.exe -n 31 127.0.0.1), POSIX-only tests stay guarded; live owned-handle GetProcessTimes() creation marker verified on Windows.
  • Focused Windows test run passes: ./cmake-build-review/tests/test_sunshine.exe --gtest_filter=ProcessTest.AppProcessIdentityProviderTracksRealChildLifecycle.
  • Existing Windows capture-only behavior preserved (no revert of it along with the new process-capture work).

This issue was generated by Muse Code powered by Meta Muse Spark

Activity

  1. mikefaille commented on Nov 17, 2026

    @mikefaille
    ContributorAuthor

    This issue was generated by Muse Code powered by Meta Muse Spark

  2. mikefaille commented on Nov 17, 2026

    @mikefaille
    ContributorAuthor

    Note: the P2 test-guard correction (identity-producer test outside the POSIX guard) landed in #6123 (branch feat/audio-lifecycle-hardening), not in this issue's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions