Skip to content

feat(audio): add playback settings and probes - #350

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/audio-settings
Nov 19, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/audio-settings

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

  • Add Settings → Audio with independent playback toggles and a persisted Stereo or Mono mode. Fresh configurations default to PC audio Off, Xbox audio On, and Stereo. Existing saved choices take precedence.
  • Share the FFmpeg and SDL playback code between streaming and a standalone Xbox ISO that can exercise playback in Xemu without a Sunshine host.
  • Add a 5.1 channel-check generator for six-channel WAV and Dolby Digital over IEC 61937. Each speaker plays in its own time slot. Live Dolby Digital 5.1 output remains on the roadmap.

Screenshot

Audio settings in Xemu showing the fresh defaults

Issues Fixed or Closed

Roadmap Issues

Testing

  • Added native coverage for the Audio menu, playback toggle defaults, and settings persistence. All 472 native tests passed with ctest --test-dir cmake-build-release --output-on-failure.
  • Built the standard Xbox release ISO and the standalone audio probe ISO. In Xemu, the probe played left-dominant stereo and matched left and right signals in mono. Both modes passed when checked against the recorded audio.
  • Generated the WAV and IEC 61937 fixtures and verified all six individual channel slots after decoding both outputs.
  • The strict Dockle API build, CMake lint, and Python lint passed.
  • Live playback from Sunshine and optical output on original Xbox hardware still need validation.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Codex helped implement and validate the changes and prepare this PR.

@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.81250% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.87%. Comparing base (dbecb06) to head (4258498).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/client_state.cpp 70.00% 0 Missing and 9 partials ⚠️
src/ui/shell_view.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   73.84%   73.87%   +0.02%     
==========================================
  Files          68       69       +1     
  Lines        7922     7950      +28     
  Branches     3464     3469       +5     
==========================================
+ Hits         5850     5873      +23     
  Misses       1091     1091              
- Partials      981      986       +5     
Flag Coverage Δ
Linux 73.13% <90.38%> (+0.04%) ⬆️
macOS 62.32% <62.71%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/app/client_state.h 98.66% <100.00%> (+0.03%) ⬆️
src/app/settings_storage.cpp 77.89% <100.00%> (+0.55%) ⬆️
src/app/settings_storage.h 100.00% <100.00%> (ø)
src/streaming/audio_configuration.cpp 100.00% <100.00%> (ø)
src/ui/shell_view.cpp 72.67% <77.77%> (-0.50%) ⬇️
src/app/client_state.cpp 75.02% <70.00%> (-0.03%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbecb06...4258498. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 36e97a9 into master Nov 19, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/audio-settings branch November 19, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants