Repository navigation
fix: recover reasoning-only model responses - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model can emit its end-of-turn token before closing its reasoning block, leaving a resumed Codex conversation with no answer or tool call. The gateway currently fails that response, and client retries can reproduce the same failure.
Recover translated Responses requests with at most one assistant-prefill continuation. Retain the conversation, generated reasoning, tools and sampling settings, and let the engine's chat template close the thinking block before continuing the answer. Keep one response ID and ordered stream, deduct consumed output tokens from the recovery budget, preserve cancellation and admission permits, and account for both generations. Unsupported continuations and repeated failures remain explicit errors; malformed tool calls and length-limited generations are not retried.
Update the locked rustls, rustls-webpki, Tokio and WebPKI root dependencies to fixed versions required by the security audit.
Validation:
make lint,make test,make test-client, andmake auditpassed on the isolated candidate.