Add bates number params to AL Document#1004
Draft
BryceStevenWilley wants to merge 2 commits intomainfrom
Draft
Conversation
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
b2e60e8 to
41a9eb2
Compare
Lets the ALDocumentBundle use `bates_number` function when generating a PDF, as well as the work-in-progress params.
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
41a9eb2 to
381af8a
Compare
Should have been `offset_horizontal`, etc.
Member
|
@BryceStevenWilley let me know when this is really ready to review/merge--looks like you still made recent changes |
Contributor
Author
|
I had been waiting for jhpyle/docassemble#898 to be merged, but missed that it just got cherry-picked and is already in 1.9.2. Needs some testing there, but it shouldn't have to change much. |
Member
|
Changing to draft--update state when it's ready to merge, and we can do a major version bump if we need if this depends on a specific Docassemble release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the ALDocumentBundle use
bates_numberfunction when generating a PDF, as well as the work-in-progress params.Depends on jhpyle/docassemble#898