Recursive directory parsing + ignore common YAML dirs we shouldn't check#9
Open
nonprofittechy wants to merge 10 commits intomainfrom
Open
Recursive directory parsing + ignore common YAML dirs we shouldn't check#9nonprofittechy wants to merge 10 commits intomainfrom
nonprofittechy wants to merge 10 commits intomainfrom
Conversation
Collaborator
BryceStevenWilley
left a comment
There was a problem hiding this comment.
A lot of comments, but really only two suggestions:
- change
include_default_ignoretocheck_all, a clearer name - add
.venvto the ignored dirs.
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dayamlchecker .now works the same asblack .andmypy ., gathering checkable files as it runs in subdirectories