Skip to content

Comments

Recursive directory parsing + ignore common YAML dirs we shouldn't check#9

Open
nonprofittechy wants to merge 10 commits intomainfrom
recursive-directory-parsing
Open

Recursive directory parsing + ignore common YAML dirs we shouldn't check#9
nonprofittechy wants to merge 10 commits intomainfrom
recursive-directory-parsing

Conversation

@nonprofittechy
Copy link
Member

  • Running dayamlchecker . now works the same as black . and mypy ., gathering checkable files as it runs in subdirectories
  • This immediately raises a bunch of false positive failures when you run in a package root. We could add some "is this a Docassemble YAML?" heuristic, but for now just going to ignore the most common ignorable directories, /sources/ and .github

Copy link
Collaborator

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of comments, but really only two suggestions:

  • change include_default_ignore to check_all, a clearer name
  • add .venv to the ignored dirs.

nonprofittechy and others added 9 commits February 23, 2026 10:02
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants