Repository navigation
fix(ardac2prd): restore Guppy sync and developer visibility - #88
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins External Secrets manifests to a cluster-supported API version and enables GitOps-managed custom objects to restore Argo CD sync while improving developer read visibility in the cluster.
Changes:
- Set
global.externalSecrets.apiVersion: external-secrets.io/v1beta1for the ardac2prd portal deployment values. - Add GitOps-managed RBAC Roles/RoleBindings for the
ardac-developersgroup (default + argocd namespaces). - Enable the
custom-objectsapplication via cluster-level-resources values so the new RBAC manifests are applied.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ardac2prd/portal.ardac.org/values.yaml |
Pins External Secrets API version for this environment to avoid using an unsupported served version. |
ardac2prd/cluster-values/custom-objects/developer-rbac.yaml |
Introduces GitOps-managed RBAC for developer visibility (and “power” access) in default/argocd namespaces. |
ardac2prd/cluster-level-resources/cluster-values.yaml |
Enables custom-objects so the new RBAC manifests are deployed by Argo CD. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
esentuna
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external-secrets.io/v1beta1API so Argo CD can sync Guppyardac-developer-power-roleand binding under GitOps management without changing its existing pod exec or pod/job creation rightsValidation
gen3-ardac2prdwas OutOfSync/Degraded because the cluster does not serveexternal-secrets.io/v1gen3-helmwith ardac2prd values: Guppy Deployment, Service, and ConfigMap are present; 17 ExternalSecret resources usev1beta1; zero usev1