Repository navigation
Fix ardac1prd WTS secret source - #101
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted configuration matches the established ARDAC environment naming pattern.
Review effort: Balanced
Findings: None
What changed in this PR
Updates ARDAC1’s WTS configuration to use the IAM-permitted, environment-prefixed secret.
Changes:
- Configures
wtsG3autoasardac1prd-default-wts-g3auto.
| File | Description |
|---|---|
ardac1prd/portal.ardac.org/values.yaml |
Sets the ARDAC1 WTS ExternalSecret source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Copilot review follow-up: confirmed the environment-prefixed secret exists in Secrets Manager, the pinned ARDAC1 chart renders exactly one WTS ExternalSecret reference to it, and the existing IRSA naming pattern permits this source. No line-level review threads were opened. |
esentuna
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point the ARDAC1 WTS ExternalSecret at the environment-prefixed Secrets Manager name allowed by its IAM policy. The historical default
wts-g3autosource does not exist in the permitted namespace.Validation
ardac1prd-default-wts-g3autogit diff --checkyamllint(one unrelated pre-existing comment-spacing warning)