Initial audio ducking implementation #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First initial implementation of audio ducking via AudioFocusManager. Looking for feedback on how it is structured and functions.
This functions through AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK which will lower any background audio during the user's interaction with Dicio. Audio ducking starts in SttInputDeviceWrapper when it detects a listening state and is held until TTS finishes in AndroidTtsSpeechDevice.onDone().
I've added some fallback releases in VoskInputDevice.stopListening() (when the user taps the mic button to cancel an interaction), MainActivity.onStop() (when the user leaves the app), and when a skill errors out.
I believe this covers all cases but could definitely use some help testing this implementation.
I've merged this into my test build - https://github.com/tylxr59/dicio-android/tree/tylxrs-build
Resolves #363