Loader#5
Merged
Merged
Conversation
CRITICAL FIX: Resolves AttributeError when backtester queries earliest dates Problem: - DataInterface.earliest_any_date() and earliest_common_date() call store.earliest(symbol) at interface.py:63 and :211 - No DataStore implementation had this method - Would crash at runtime during backtest start date determination Solution: - Added earliest() method to base.py abstract interface - Implemented in CSVDataStore (returns df.index.min()) - Implemented in ParquetDataStore (returns df.index.min()) - Implemented in NoisyDataStore (delegates to base_store) - Implemented in MarketDataLoaderAdapter (returns df.index[0]) Testing: - Added test_earliest_date() for ParquetDataStore - Updated test_delegation_methods() for NoisyDataStore - All 21 tests passing (was 20 before) Impact: - Fixes: Backtester can now determine earliest available dates - No breaking changes (pure addition) - Symmetric with existing latest() method Related: plan/01-critical-blockers.md Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Created detailed planning documents to track refactor status and guide completion to merge. Contents: - plan/README.md - Overview and quick links - plan/01-critical-blockers.md - Must-fix issues before merge - plan/02-architecture-overview.md - Complete system design docs - plan/03-branch-cleanup.md - Branch management strategy - plan/04-merge-readiness.md - Merge checklist and timeline Purpose: - Document refactor status (80-85% complete) - Track critical blockers - Provide merge path - Enable future reference Status: One blocker resolved (earliest() method), remaining blockers documented in 01-critical-blockers.md Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
All critical blockers have been fixed: ✅ earliest() method implemented (commit 5b87687) ✅ cvxpy dependency verified (already in pyproject.toml) ✅ Full test suite passing (521 tests) Status: Ready for merge to main Remaining items are optional code quality improvements that don't block the merge. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.