Skip to content

JVNAUTOSCI-1458 Use shared copied-state feedback for diagnostics button#245

Merged
witbrock merged 1 commit intomainfrom
JVNAUTOSCI-1458-copy-diagnostics-success-state
Mar 16, 2026
Merged

JVNAUTOSCI-1458 Use shared copied-state feedback for diagnostics button#245
witbrock merged 1 commit intomainfrom
JVNAUTOSCI-1458-copy-diagnostics-success-state

Conversation

@witbrock
Copy link
Member

Summary

  • route the thinking-card diagnostics button through the shared JSON copy feedback helper
  • apply the shared copied/error visual treatment to thinking-card actions so success becomes the lighter copied-state instead of the legacy green success state
  • add regression coverage for diagnostics-button copied-state behaviour and reset semantics

Validation

  • npx jest src/frontend/web/von_interface/static/js/test/chatTab.test.js src/frontend/web/von_interface/static/js/test/copyJsonButtonState.test.js --runInBand
  • npx pyright src/frontend/web/von_interface/static/js/chatTab.js src/frontend/web/von_interface/static/js/test/chatTab.test.js (not a meaningful repo signal here; pyright mis-parses these frontend ES-module JS files from line 1 and reports broad syntax noise unrelated to this change)

@witbrock witbrock merged commit 003f75c into main Mar 16, 2026
1 check passed
@witbrock witbrock deleted the JVNAUTOSCI-1458-copy-diagnostics-success-state branch March 16, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant