Conversation
…ed again - Use plain text in <summary> for collapsible diagnostic rows instead of interactive <button> elements that block native <details> toggle - Skip event.preventDefault in bindConceptSelectionClicks when click target is inside a <summary>/<details> element - Add two regression tests for the toggle behaviour - Update two existing tests to match new plain-text summary output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cosmetic bug where thinking card diagnostic
Details
rows could be expanded but not collapsed.Root cause: Two interacting issues:
<button>elements inside<summary>intercepted clicks, preventing native<details>togglebindConceptSelectionClickscalledevent.preventDefault()on concept link clicks, suppressing the<summary>default toggle actionFix:
<summary>elements now use plain text instead of<button>HTMLbindConceptSelectionClicksskipspreventDefaultwhen click originates inside a<summary>Tests: 2 regression tests added, 2 existing tests updated. All 115 chatTab tests pass.
Resolves JVNAUTOSCI-1441