fix: set Windows binary subsystem to GUI - #176
Merged
Merged
Conversation
The Windows build was missing the `-H windowsgui` linker flag, causing the PE binary to use the console subsystem (IMAGE_SUBSYSTEM_WINDOWS_CUI). This made Windows display a "this is a command-line application" error when launched from shortcuts, URL handlers, or double-click. Add an EXTRA_LDFLAGS variable to the binary task and pass `-H windowsgui` for the windows-amd64 target, setting the correct GUI subsystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows installer produces a binary that fails to launch with a "this is a command-line application" error when opened from shortcuts, URL handlers, or double-click.
Root cause
The Windows build was missing the
-H windowsguilinker flag, so the Go compiler produced a PE binary withIMAGE_SUBSYSTEM_WINDOWS_CUI(console subsystem) instead ofIMAGE_SUBSYSTEM_WINDOWS_GUI.Changes
EXTRA_LDFLAGSvariable to thebinarytask inTaskfile.build.yml(defaults to empty, no impact on other platforms)EXTRA_LDFLAGS: "-H windowsgui"for thewindows-amd64targetTesting