Conversation
The game clock drifted fast because on_tick() assumed exactly 100ms between Qt timer fires. Now measures actual wall-clock elapsed time via QElapsedTimer with remainder tracking. The highlights button always ran `reeln game highlights` regardless of the "Game Finished" checkbox. Now dispatches `reeln game segment <N>` (with integer period number) when unchecked, and `reeln game highlights` when checked. Hotkey follows the same logic. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_tick()assumed exactly 100ms between Qt timer fires, causing the game clock to drift fast. Now usesQElapsedTimerto measure actual wall-clock elapsed time with remainder tracking so fractional tenths aren't lost.reeln game highlightsregardless of the "Game Finished" checkbox state. Now correctly dispatchesreeln game segment <N>(integer period number) when unchecked, andreeln game highlightswhen checked. Hotkey follows the same logic.Test plan
reeln game segment 1(notreeln game highlights)reeln game segment 4reeln game highlights🤖 Generated with Claude Code