feat: Period labels, faceoff wins, and penalty queue#3
Merged
Conversation
…queue Add three features and two bug fixes for the next release: - Configurable period labels: sport-specific defaults (e.g. hockey 1,2,3,OT,OT2,OT3,OT4) with external file override via period_labels.txt and Edit button in Game Settings - Faceoff wins counter: home/away tracking for hockey/lacrosse with dock UI, hotkeys, text file output, and JSON persistence - Penalty queue: only 2 penalties per team tick simultaneously, extras auto-start on expiry - Fix: Start/Stop button resets to green when clock auto-stops at 0:00 - Fix: Penalty timers freeze when period clock reaches 0:00 100% line coverage on scoreboard-core.c maintained with comprehensive new tests. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
period_labels.txt. "Edit..." button in Game Settings opens the file in the user's default text editor. File watcher applies changes live.home_faceoffs.txt/away_faceoffs.txtoutput files, JSON persistence, and tooltips on all stat rows.SCOREBOARD_MAX_RUNNING_PENALTIES), matching hockey rules. Additional penalties queue and auto-start when earlier ones expire. Dock UI shows queued penalties with "(queued)" suffix. Text file output shows only running penalties.Test plan
make dev— all 7 test binaries passmake coverage— 100% line coverage on scoreboard-core.cmake install && make run— verify in OBS:uv run pytest tests/— 81 tests pass🤖 Generated with Claude Code