Skip to content

fix: Timestamps button visibility and New Game lifecycle#2

Merged
JRemitz merged 1 commit intomainfrom
fix/timestamps-button-lifecycle
Mar 21, 2026
Merged

fix: Timestamps button visibility and New Game lifecycle#2
JRemitz merged 1 commit intomainfrom
fix/timestamps-button-lifecycle

Conversation

@JRemitz
Copy link
Copy Markdown
Contributor

@JRemitz JRemitz commented Mar 21, 2026

Summary

  • Timestamps button persists across OBS restarts — visibility now checks timestamps.txt on disk, not just the in-memory event log
  • Click handler falls back to file — when in-memory log is empty (e.g. after restart), reads timestamps.txt directly and copies to clipboard
  • New Game clears timestamps — truncates timestamps.txt and hides the button
  • Stream start warns about previous timestamps — shows a "Start Fresh / Keep" dialog so users don't accidentally lose chapter markers from a previous game

Test plan

  • make build && make test — all 7 test suites pass
  • make coverage — 100% line coverage on scoreboard-core
  • Manual: start stream, log events, stop stream, restart OBS → button visible, copy works
  • Manual: click New Game → button disappears, timestamps.txt emptied
  • Manual: with timestamps from previous game, start new stream → dialog asks keep/clear

🤖 Generated with Claude Code

The "Copy Timestamps to Clipboard" button disappeared after OBS restarts
or stream stops because visibility was tied solely to the in-memory event
log. Now the button also checks timestamps.txt on disk, the click handler
falls back to reading the file, New Game truncates the file, and stream
start warns if previous timestamps exist with a keep/clear dialog.

Co-Authored-By: Claude <noreply@anthropic.com>
@JRemitz JRemitz self-assigned this Mar 21, 2026
@JRemitz JRemitz merged commit 20d87ad into main Mar 21, 2026
7 checks passed
@JRemitz JRemitz deleted the fix/timestamps-button-lifecycle branch March 21, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant