Skip to content

The third review - #6

Merged
truongwp merged 5 commits into
masterfrom
review-3
Apr 16, 2026
Merged

truongwp merged 5 commits into
masterfrom
review-3

Conversation

@truongwp

Copy link
Copy Markdown
Collaborator

Changes required to your node package
Thank you for addressing the previous review feedback — error handling, credential type, and password masking are all resolved. We found a few more items during this round.

High Priority Issues (BLOCKING)
[HIGH] getCredentials() throws when credentials are not configured

File: nodes/FormidableForms/FormidableFormsTrigger.node.ts:79
The credential is declared with required: false (line 31), meaning users can skip configuring it. However, the webhook handler calls this.getCredentials('formidableFormsApi') unconditionally — when no credential is set, this throws an unhandled error, crashing the webhook. Either wrap the call in a try/catch (skipping token verification when credentials are absent) or set required: true if token verification should be mandatory.
[HIGH] Credential testedBy does not match credential test method

File: credentials/FormidableFormsApi.credentials.ts:13
testedBy is set to 'formidableFormsTrigger', but the method key in the node's methods.credentialTest is 'formidableFormsApiTest' (see FormidableFormsTrigger.node.ts:51). This mismatch means n8n cannot locate the test function, so the credential test button will not work. Change testedBy to 'formidableFormsApiTest'. The eslint-disable comment on line 7 can also be removed since a credential test is implemented.
Medium Priority Issues (RECOMMENDED)
[MEDIUM] Unnecessary displayOptions on credential reference

File: nodes/FormidableForms/FormidableFormsTrigger.node.ts:33-35
displayOptions: { show: {} } is a no-op — an empty show condition means "always show", which is already the default. Remove the displayOptions property.
Low Priority Issues (NOT BLOCKING)
[LOW] Empty homepage in package.json

File: package.json:6
Set it to the GitHub repository URL or the Formidable Forms docs page (e.g. https://github.com/Strategy11/n8n-nodes-formidable-forms).
[LOW] Publish workflow missing --provenance flag

File: .github/workflows/npmjs.yml:29
Starting May 1st 2026, all verified nodes must include an npm provenance statement. The workflow already has id-token: write — add --provenance to the npm publish command.

@truongwp
truongwp merged commit 5d40ac4 into master Apr 16, 2026
1 check passed
@truongwp
truongwp deleted the review-3 branch April 16, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant