Skip to content

Second review stage - #5

Merged
truongwp merged 4 commits into
masterfrom
review-2
Apr 13, 2026
Merged

truongwp merged 4 commits into
masterfrom
review-2

Conversation

@truongwp

Copy link
Copy Markdown
Collaborator

Review details:

Changes required to your node package
While reviewing your node we have found the below that will need to be addressed.

Critical Issues (BLOCKING)
[MEDIUM] Missing error handling with n8n error classes

File: nodes/FormidableForms/FormidableFormsTrigger.node.ts:45-84
Required action: Replace custom error handling using raw HTTP responses with NodeApiError or NodeOperationError from 'n8n-workflow'
High Priority Issues (BLOCKING)
None identified.

Medium Priority Issues (RECOMMENDED)
[MEDIUM] Token field lacks password type option

File: nodes/FormidableForms/FormidableFormsTrigger.node.ts:36
Recommended action: Add typeOptions: { password: true } to mask sensitive token data in the UI
[MEDIUM] No credentials defined

File: package.json:33
Recommended action: Create a proper credential type for Formidable Forms token to enable credential reuse and improve security management

@truongwp
truongwp merged commit ec11d3d into master Apr 13, 2026
1 check passed
@truongwp
truongwp deleted the review-2 branch April 13, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant