Skip to content

Fix lint violations from latest n8n community-nodes rules - #11

Merged
truongwp merged 1 commit into
masterfrom
fix-lint-webhook-lifecycle-and-icons
Aug 10, 2026
Merged

truongwp merged 1 commit into
masterfrom
fix-lint-webhook-lifecycle-and-icons

Conversation

@truongwp

Copy link
Copy Markdown
Collaborator

webhook-lifecycle-complete (error): the rule fires on any node declaring a non-empty webhooks array. Formidable Forms exposes no API for n8n to register or remove a form action, so the lifecycle is a documented no-op; checkExists returns true so n8n never attempts a remote registration it cannot perform.

icon-prefer-themed-variants (warning): the logo used #3B3B3B, which is invisible against dark backgrounds. Adds a dark variant and switches both the node and credential to the { light, dark } form.

Verified with @n8n/node-cli@0.42.2 (the version n8n's review pipeline runs) — exit 0, no violations. The pinned local 0.17.0 predates both rules.

webhook-lifecycle-complete (error): the rule fires on any node declaring
a non-empty `webhooks` array. Formidable Forms exposes no API for n8n to
register or remove a form action, so the lifecycle is a documented no-op;
`checkExists` returns true so n8n never attempts a remote registration it
cannot perform.

icon-prefer-themed-variants (warning): the logo used #3B3B3B, which is
invisible against dark backgrounds. Adds a dark variant and switches both
the node and credential to the { light, dark } form.

Verified with @n8n/node-cli@0.42.2 (the version n8n's review pipeline
runs) — exit 0, no violations. The pinned local 0.17.0 predates both rules.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@truongwp
truongwp merged commit e8fd1a7 into master Aug 10, 2026
1 check passed
@truongwp
truongwp deleted the fix-lint-webhook-lifecycle-and-icons branch August 10, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant