Repository navigation
Fix lint violations from latest n8n community-nodes rules - #11
Merged
Merged
Conversation
webhook-lifecycle-complete (error): the rule fires on any node declaring
a non-empty `webhooks` array. Formidable Forms exposes no API for n8n to
register or remove a form action, so the lifecycle is a documented no-op;
`checkExists` returns true so n8n never attempts a remote registration it
cannot perform.
icon-prefer-themed-variants (warning): the logo used #3B3B3B, which is
invisible against dark backgrounds. Adds a dark variant and switches both
the node and credential to the { light, dark } form.
Verified with @n8n/node-cli@0.42.2 (the version n8n's review pipeline
runs) — exit 0, no violations. The pinned local 0.17.0 predates both rules.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webhook-lifecycle-complete (error): the rule fires on any node declaring a non-empty
webhooksarray. Formidable Forms exposes no API for n8n to register or remove a form action, so the lifecycle is a documented no-op;checkExistsreturns true so n8n never attempts a remote registration it cannot perform.icon-prefer-themed-variants (warning): the logo used #3B3B3B, which is invisible against dark backgrounds. Adds a dark variant and switches both the node and credential to the { light, dark } form.
Verified with @n8n/node-cli@0.42.2 (the version n8n's review pipeline runs) — exit 0, no violations. The pinned local 0.17.0 predates both rules.