Repository navigation
Show the on/off toggle for installed Boosts on the Add-Ons page - #3720
Conversation
Match installed Boosts by their updater download id or plugin name when the API plugin path does not match the installed folder, so the Add-Ons page shows their toggle and activates the right file. Map the folder-style Boost slugs the API now sends to the existing default descriptions and icons. The short slugs still work for older cached feeds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Nov 17, 2026 5:58p.m. | Review ↗ | |
| JavaScript | Nov 17, 2026 5:58p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Nov 17, 2026 6:02p.m. | Review ↗ | |
| JavaScript | Nov 17, 2026 6:02p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
The API now sends folder-style Boost slugs, and the short slugs never shipped in a release. Key the default Boost descriptions and icons on the current slugs only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Approve. Both fixes do what the description says, and I found nothing blocking.
- Installed Boosts now match by
download_id(active) or plugin name (inactive) when the API path misses, and the matched file is also what the Activate/Deactivate buttons get ($addon['plugin']). - The icon and excerpt maps now use the
formidable-*slugs. I greppedclasses,testsandjs/srcfor the old short slugs and found no remaining uses.
Tests run: phpunit --filter test_FrmBoostsMarketplace at cca1b4b → OK (8 tests, 49 assertions), in the wordpress-develop harness (PHP 8.4). CI skips the PHPUnit jobs on this PR, so this was a local run. The new test errors against master's controller (no get_boost_plugin_file), and fails when the download_id match is removed.
Live before/after: I ran prepare_addons() on a three-Boost feed in the same harness, with Advanced Modals installed inactive as frm-advanced-modals.php. On master it came back installed=false, status=not-installed, so it shows Get Boost, and all three icons fall back to the Formidable logo. On this PR it comes back installed=true, status=installed with an activate URL, plugin formidable-advanced-modals/frm-advanced-modals.php, and the popups, celebrations and bulk-edit icons. A Boost that is not installed (Bulk Edit) stays not-installed with the API path.
Not run: the Add-Ons page in a browser (no screenshot of the toggle), the active-Boost download_id path against a real FrmAddon registration (covered by the unit test only), code-review / security-review skills (I read the whole 118-line diff instead), PHPCS. DeepSource PHP is red. It posted no inline comments, and its summary says the issues it found are outside this diff; I did not open the dashboard.
Installed Boosts were locked on the Add-Ons page with a "Get Boost" button instead of the on/off toggle other add-ons get. The plugin path the API sent for a Boost did not match the folder it is installed in, so Lite never saw it as installed. Lite now matches an installed Boost by its updater download id (active Boosts) or plugin name (inactive Boosts) when the API path misses, and the toggle's Activate/Deactivate buttons send the matched file.
The API now sends folder-style Boost slugs (
formidable-bulk-editinstead ofbulk-edit), which dropped the default descriptions and icons on every Boost card. Both lookups are now keyed on the current slugs. The short slugs never shipped in a release, so they are removed.The API still sends
formidable-advanced-modals/formidable-advanced-modals.phpfor Advanced Modals, but its main file isfrm-advanced-modals.php. The plugin name match covers it. Once the API path is corrected,get_boost_plugin_file()can be removed.Testing
buy_url.🤖 Generated with Claude Code