Repository navigation
Move the form outline to a floating button with a popover - #3666
Conversation
Moves the outline out of the sidebar tab into a popover opened from a floating "Form outline" button at the bottom right of the builder canvas, matching the floating buttons on the Styles page. - Shows only once the form has a page break. - Current page is marked with a bar as well as color. - Arrow keys, Home/End and Enter navigate the results (Safari's Tab skips buttons). - Search stays fixed while the list scrolls; focused rows get a visible ring. - Page rows show a field count that leaves out sections and page breaks. - A page named after its first section no longer lists that name twice. - Sits above the bottom tab bar on screens under 960px. - Adds the Iconic map icon to the sprite as frm_map_icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
DeepSource Code ReviewWe reviewed changes in See full review on DeepSource ↗ Code Review Summary
Important AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Nov 4, 2026 2:32p.m. | Review ↗ | |
| JavaScript | Nov 4, 2026 2:32p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Request Changes at dc20c4b: one blocking issue, found by loading this PR in a builder on a Lite + Pro Playground env (3-page form, 1400x900).
Blocking: the Formidable Checklist covers the Form outline button and its popover, and a click lands on "Dismiss Checklist". The checklist is position: fixed; z-index: 9999 at the bottom right of the builder. The new button wrapper is z-index: 20 and the popover is 100, in the same corner. With the checklist expanded (the default until someone dismisses or completes it):
// elementFromPoint at the centre of #frm-builder-outline-toggle
"frm-checklist__dismiss frm-btn-unstyled ..."
// elementFromPoint at the centre of the open popover
"frm-checklist__step-title ..."The first screenshot shows the popover open behind the checklist, with the button not visible. A person clicking where the button should be dismisses the checklist instead. Once the checklist was dismissed the button and popover render correctly:
Fix: when .frm-checklist is in the DOM, keep the button and popover clear of it (offset by the checklist width, or sit above it), or stack above it. I only checked the expanded checklist. I did not test its collapsed state.
Checked live and fine: the button only shows once the form has a page break and the old "Form Outline" tab is gone (#frm-builder-outline-tab absent). Open state sets aria-expanded="true" and moves focus to the search box. Page rows read "Page 1: First name 2 fields / Page 2: Company 2 fields / Page 3: Phone 1 field", so page breaks are left out of the counts. Arrow Down, Arrow Up, Home and End move focus as described, and Arrow Up from the first row returns to search. A search for zzz shows "No results for “zzz”" with the new hint. A pointerdown outside closes it, jumping to a page keeps it open, and the page mark follows scrolling on a tall form (marker moved 1, 2, 3, then back to 1). At 800px the button sits above the bottom tab bar.
Non-blocking:
- The current-page mark never reaches short trailing pages.
updateDock()only counts a page once its pill scrolls above the top edge of#post-body-content. On my 7-field form the canvas stopped scrolling with page 3's pill 462px below the top, so the mark stayed on Page 1 even after jumping to Page 3. It worked once I added padding to make the form tall. A form whose last page is short will never mark it. - Enter in the search box jumps to the page row, not the match. Searching
messlistsPage 2: Companyfirst, thenMessage. Enter clicks the first button, so it scrolled to Company (a text field) rather than Message. Consider skipping page rows when a query is active, or making Enter pick the first field or section row. scroller(#post-body-content) is used without a null check inupdateDockand the scroll listener. It exists in the builder today, but a missing element would throw insideinitFormOutline.
Not exercised: the Cypress spec was changed but PR CI skipped Cypress, PHPUnit and the linters, and I did not run it. I did not open the popover at 800px, test translated strings, or test RTL. Pro on the env is from 2026-10-15, so the page pills come from an older Pro build.


Follow-up to #3636.
Cypress test updated but not run locally.
🤖 Generated with Claude Code