Skip to content

Move the form outline to a floating button with a popover - #3666

Merged
Crabcyborg merged 1 commit into
form_outlinefrom
form_outline-ui
Nov 4, 2026
Merged

Crabcyborg merged 1 commit into
form_outlinefrom
form_outline-ui

Conversation

@tuguirazvan

Copy link
Copy Markdown
Collaborator

Follow-up to #3636.

  • The outline opens from a floating "Form outline" button at the bottom right of the builder, like the buttons on the Style page, instead of a sidebar tab
  • The button only shows once the form has a page break
  • The page you're on is marked with a bar in the list
  • Arrow keys, Home/End and Enter move through the results; focused rows get a visible ring
  • Search stays at the top while the list scrolls
  • Each page shows its number of fields, not counting sections or page breaks
  • On screens narrower than 960px the button sits above the bottom tab bar
  • Adds a map icon to the icon sprite

Cypress test updated but not run locally.

🤖 Generated with Claude Code

Moves the outline out of the sidebar tab into a popover opened from a
floating "Form outline" button at the bottom right of the builder canvas,
matching the floating buttons on the Styles page.

- Shows only once the form has a page break.
- Current page is marked with a bar as well as color.
- Arrow keys, Home/End and Enter navigate the results (Safari's Tab skips buttons).
- Search stays fixed while the list scrolls; focused rows get a visible ring.
- Page rows show a field count that leaves out sections and page breaks.
- A page named after its first section no longer lists that name twice.
- Sits above the bottom tab bar on screens under 960px.
- Adds the Iconic map icon to the sprite as frm_map_icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@deepsource-io

deepsource-io Bot commented Nov 4, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in e5a397b...dc20c4b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Nov 4, 2026 2:32p.m. Review ↗
JavaScript Nov 4, 2026 2:32p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@deepsource-io

deepsource-io Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in e5a397b...dc20c4b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Nov 4, 2026 2:32p.m. Review ↗
JavaScript Nov 4, 2026 2:32p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@franky-the-going-merry franky-the-going-merry Bot added the franky-working Franky is actively reviewing this label Nov 4, 2026

@franky-the-going-merry franky-the-going-merry Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes at dc20c4b: one blocking issue, found by loading this PR in a builder on a Lite + Pro Playground env (3-page form, 1400x900).

Blocking: the Formidable Checklist covers the Form outline button and its popover, and a click lands on "Dismiss Checklist". The checklist is position: fixed; z-index: 9999 at the bottom right of the builder. The new button wrapper is z-index: 20 and the popover is 100, in the same corner. With the checklist expanded (the default until someone dismisses or completes it):

// elementFromPoint at the centre of #frm-builder-outline-toggle
"frm-checklist__dismiss frm-btn-unstyled ..."
// elementFromPoint at the centre of the open popover
"frm-checklist__step-title ..."

Checklist over the outline button

The first screenshot shows the popover open behind the checklist, with the button not visible. A person clicking where the button should be dismisses the checklist instead. Once the checklist was dismissed the button and popover render correctly:

Outline open after the checklist was dismissed

Fix: when .frm-checklist is in the DOM, keep the button and popover clear of it (offset by the checklist width, or sit above it), or stack above it. I only checked the expanded checklist. I did not test its collapsed state.

Checked live and fine: the button only shows once the form has a page break and the old "Form Outline" tab is gone (#frm-builder-outline-tab absent). Open state sets aria-expanded="true" and moves focus to the search box. Page rows read "Page 1: First name 2 fields / Page 2: Company 2 fields / Page 3: Phone 1 field", so page breaks are left out of the counts. Arrow Down, Arrow Up, Home and End move focus as described, and Arrow Up from the first row returns to search. A search for zzz shows "No results for “zzz”" with the new hint. A pointerdown outside closes it, jumping to a page keeps it open, and the page mark follows scrolling on a tall form (marker moved 1, 2, 3, then back to 1). At 800px the button sits above the bottom tab bar.

Non-blocking:

  1. The current-page mark never reaches short trailing pages. updateDock() only counts a page once its pill scrolls above the top edge of #post-body-content. On my 7-field form the canvas stopped scrolling with page 3's pill 462px below the top, so the mark stayed on Page 1 even after jumping to Page 3. It worked once I added padding to make the form tall. A form whose last page is short will never mark it.
  2. Enter in the search box jumps to the page row, not the match. Searching mess lists Page 2: Company first, then Message. Enter clicks the first button, so it scrolled to Company (a text field) rather than Message. Consider skipping page rows when a query is active, or making Enter pick the first field or section row.
  3. scroller (#post-body-content) is used without a null check in updateDock and the scroll listener. It exists in the builder today, but a missing element would throw inside initFormOutline.

Not exercised: the Cypress spec was changed but PR CI skipped Cypress, PHPUnit and the linters, and I did not run it. I did not open the popover at 800px, test translated strings, or test RTL. Pro on the env is from 2026-10-15, so the page pills come from an older Pro build.

@franky-the-going-merry franky-the-going-merry Bot removed franky-review franky-working Franky is actively reviewing this labels Nov 4, 2026

@Crabcyborg Crabcyborg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Razvan!

🚀

@Crabcyborg
Crabcyborg merged commit ad7e2da into form_outline Nov 4, 2026
55 of 56 checks passed
@Crabcyborg
Crabcyborg deleted the form_outline-ui branch November 4, 2026 14:59
@franky-the-going-merry franky-the-going-merry Bot added franky-working Franky is actively reviewing this and removed franky-working Franky is actively reviewing this labels Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants