Fix multiple Set-Cookie headers not being captured#3
Closed
noahsmiths wants to merge 1 commit intoStopMakingThatBigFace:mainfrom
Closed
Fix multiple Set-Cookie headers not being captured#3noahsmiths wants to merge 1 commit intoStopMakingThatBigFace:mainfrom
noahsmiths wants to merge 1 commit intoStopMakingThatBigFace:mainfrom
Conversation
Owner
|
Hey, @noahsmiths, thanks for the PR and for taking the time to dig into this! This has actually been addressed in v1.0.0 — multiple Set-Cookie headers are now handled correctly. Feel free to check it out, there's also a bunch of other improvements in that release worth looking at. Closing this for now, but appreciate the contribution! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This fixes cookie parsing logic to include all "set-cookie" responses. Previously, only the most recent of the "set-cookie" headers within a response would be respected and parsed.
I don't really know Rust well and had copilot originally author this PR, so apologies if it's not great. I did my best to check it out and make sure it works, and from my testing this should be a quality fix.
🔗 Related Issue
N/A
🎯 Type of Change