Respect write_spin_centers parameter for PDB HEADER and TER strings#196
Merged
mtessmer merged 1 commit intoStollLab:mainfrom Oct 13, 2025
Merged
Respect write_spin_centers parameter for PDB HEADER and TER strings#196mtessmer merged 1 commit intoStollLab:mainfrom
mtessmer merged 1 commit intoStollLab:mainfrom
Conversation
…y if write_spin_centers is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the PDB HEADER and TER statements written at the end of PDB files by xl.save() were not controlled by the write_spin_centers boolean parameter. This caused empty PDB blocks to be written even when write_spin_centers=False, leading to malformed PDB files that might cause issues for other progrmas, such as warnings thrown out by PyMOL. This pull request fixes the issue by placing the code that writes HEADER and TER statements under the same conditional check for write_spin_centers. Now these statements are only written when spin centers are actually being saved to the file.