Open
Conversation
stirlingbot
bot
added
the
Front End
jbrunton96
requested review from
ConnorYoh,
EthanHealy01,
Frooodle and
reecebrowne
as code owners
dosubot
bot
added
the
size:L
Contributor
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://23.22.230.180:5934 🔐 Secure HTTPS URL: https://5934.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Ages ago I made #4835 to try and fix all the
anytype usage in the system but never got it finished, and there were just too many to review and ensure it still worked. There's even more now.My new tactic is to fix folder by folder. This fixes the
anytyping in thesaas/folder, and also enablesno-unnecessary-type-assertion, which really helps reduce pointlessascasts that AI generates when the type is already known. I hope to expand both of these to the rest of the folders soon, but one folder is better than none.