refactor(docker): consolidate JVM options and improve dynamic memory computation#5933
Draft
balazs-szucs wants to merge 6 commits intoStirling-Tools:mainfrom
Draft
refactor(docker): consolidate JVM options and improve dynamic memory computation#5933balazs-szucs wants to merge 6 commits intoStirling-Tools:mainfrom
balazs-szucs wants to merge 6 commits intoStirling-Tools:mainfrom
Conversation
…computation Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Frooodle
reviewed
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the container startup/JVM configuration to consolidate JVM option selection into a single _JVM_OPTS source and adjusts dynamic JVM memory percentage computation in init-without-ocr.sh.
Changes:
- Simplified dynamic memory computation (removed profile-based branches; adjusted Initial/Max RAM % for mid/large containers).
- Consolidated JVM option selection to
JAVA_BASE_OPTS>_JVM_OPTS> fallback defaults, and added dynamicConcGCThreadssizing based on CPU count. - Updated embedded Docker images to set a single
_JVM_OPTS(Shenandoah generational) instead of balanced/performance profiles.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/init-without-ocr.sh | Removes profile-based selection, tweaks memory sizing, adds CPU-based ConcGCThreads, consolidates JVM option sourcing. |
| docker/embedded/Dockerfile.ultra-lite | Replaces profile env vars with single _JVM_OPTS default. |
| docker/embedded/Dockerfile.fat | Replaces profile env vars with single _JVM_OPTS default (currently has a malformed flag string). |
| docker/embedded/Dockerfile | Replaces profile env vars with single _JVM_OPTS default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Collaborator
Author
|
/deploypr |
Contributor
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://23.22.230.180:5933 This deployment will be automatically cleaned up when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5866
Description of Changes
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)