Fix incorrect connections in radar plots due to variable ordering#159
Merged
Conversation
Ensure consistent ordering between angular positions (x scale) and polygon drawing in radar plots. Previously, `geom_polygon()` connected points using the row order of the data, which could differ from the order of variables displayed on the radar axes. This resulted in incorrect connections between non-adjacent variables. Fix by explicitly setting the factor levels of `var` to match the intended ordering and aligning data ordering before plotting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in radar plots where polygon lines incorrectly connect non-adjacent variables.
Problem
geom_polygon() was drawing segments based on the row order of the data, while the angular positions of variables were determined independently via the discrete x scale. When these orders differed, the resulting polygons were visually incorrect, with lines crossing between unrelated variables.
Solution
This ensures that:
Linked issues
Closes #158