Fix bugs, improve error handling, update packages, and add unit tests - #51
Merged
Conversation
Steveiwonder
commented
Apr 20, 2026
Owner
- Fix InMemoryFakeDataSource.GetCount() returning table count instead of row count
- Fix SqlDataSource.GetData() connection leak (missing using statement)
- Fix race condition in unique value tracking (HashSet not thread-safe)
- Fix GetUniqueValue double-check pattern replaced with GetOrAdd + lock
- Make BogusDataProvider._supported static readonly
- Rename SqlDataPovider.cs to SqlDataProvider.cs (typo fix)
- Replace generic Exception throws with InvalidOperationException throughout
- Add File.Exists checks with descriptive errors in Config.Load()
- Add null/empty guard for SourceColumns in MaskComputed
- Update all NuGet packages to latest versions
- Add 65 unit tests covering BogusDataProvider, Extensions, Utils, DataSourceProvider, DataMasker, and InMemoryFakeDataSource
- Add UseList feature to ColumnConfig for random selection from a predefined list
- Add InternalsVisibleTo for DataMasker.Tests
- Fix InMemoryFakeDataSource.GetCount() returning table count instead of row count - Fix SqlDataSource.GetData() connection leak (missing using statement) - Fix race condition in unique value tracking (HashSet not thread-safe) - Fix GetUniqueValue double-check pattern replaced with GetOrAdd + lock - Make BogusDataProvider._supported static readonly - Rename SqlDataPovider.cs to SqlDataProvider.cs (typo fix) - Replace generic Exception throws with InvalidOperationException throughout - Add File.Exists checks with descriptive errors in Config.Load() - Add null/empty guard for SourceColumns in MaskComputed - Update all NuGet packages to latest versions - Add 65 unit tests covering BogusDataProvider, Extensions, Utils, DataSourceProvider, DataMasker, and InMemoryFakeDataSource - Add UseList feature to ColumnConfig for random selection from a predefined list - Add InternalsVisibleTo for DataMasker.Tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Make SqlDataProvider and SqlDataSource injectable with IDbConnection so they can be tested without a live SQL Server. Add Microsoft.Data.Sqlite to the test project and use shared-cache in-memory databases for integration-style tests. Overall coverage: 95.1% line, 95.3% branch.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30524701 | Triggered | Generic Password | cd3d9df | src/DataMasker.Tests/DataSources/SqlDataSourceTests.cs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.