[COFFE] Stratix IV VPR dump out functionality - #14
Draft
ahmedelsousy wants to merge 3 commits into
Draft
Conversation
SB and CB MUXes and buffer sizings. Tested with SIV. VPR Passes tested with: "bgm" "blob_merge" "sha" "stereovision0" "raygentop"
Comment on lines
+865
to
+866
| if rr_sw.name is None: | ||
| continue |
Owner
There was a problem hiding this comment.
In what case does this happen?
Contributor
Author
There was a problem hiding this comment.
This is just a failsafe it is not really needed. I wasn't sure of how this would be done for the non-RRG flow so it is not really a problem for the RRG flow.
StephenMoreOSU
left a comment
StephenMoreOSU
left a comment
Owner
There was a problem hiding this comment.
LGTM, with the exceptions of the comments.
Owner
There was a problem hiding this comment.
Lots of diffs here, could you summarize what was deleted / added in the PR?
Contributor
Author
There was a problem hiding this comment.
What was deleted here is the old VPR emission logic which emits the VPR architecture file line by line from inside the function. That is why there is a lot of deletion. What was added was the new patching logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
third_party/vtrTests
bgm;blob_merge;sha;stereovision0;raygentop. All pass