Skip to content

fix: resolve CI lint error and add CI workflow with status badge#41

Open
teeschima wants to merge 4 commits into
StepFi-app:mainfrom
teeschima:fix/ci-issues
Open

fix: resolve CI lint error and add CI workflow with status badge#41
teeschima wants to merge 4 commits into
StepFi-app:mainfrom
teeschima:fix/ci-issues

Conversation

@teeschima

Copy link
Copy Markdown

Summary

This PR fixes the CI pipeline by resolving a lint error in Navbar.tsx and adding a GitHub Actions CI workflow with a status badge to README.md.

Changes

Navbar.tsx lint fix

  • Removed the useEffect that called setMobileOpen(false) on pathname change, which violated the react-hooks/set-state-in-effect rule
  • Added onClick={() => setMobileOpen(false)} directly to each mobile nav Link element instead

CI workflow

  • The .github/workflows/ci.yml file already existed with the correct configuration: runs on every PR to main, checks out code, sets up Node 20, installs deps, lints, and builds

Status badge

  • Added a CI status badge to README.md pointing to the workflow

Verification

  • npm run lint — passes (0 errors)
  • npm run build — passes (exit 0)

Closes #17

…orage usage

- Add Content-Security-Policy, HSTS, X-Frame-Options, and other security headers to vercel.json and netlify.toml
- Install DOMPurify and create src/lib/sanitize.ts for user content sanitization
- Sanitize all user-generated content in LearnerProfile.tsx and VendorDashboard.tsx
- Consolidate localStorage token access through zustand persist store in api.ts
- Remove redundant direct localStorage calls from user.store.ts
@teeschima teeschima force-pushed the fix/ci-issues branch 2 times, most recently from 63180e5 to 6d70e88 Compare June 17, 2026 16:18
@EmeditWeb

Copy link
Copy Markdown
Member

fix merge conflicts

@StepFi-app StepFi-app locked as spam and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add GitHub Actions CI for StepFi-Web

4 participants